Skip to content

feat: full-population reviewers/issues/PR ranking (identity in GraphQL, no getUser)#233

Merged
Progi1984 merged 3 commits into
PrestaShop:masterfrom
PrestaEdit:feat/full-population-leaderboards
Jul 1, 2026
Merged

feat: full-population reviewers/issues/PR ranking (identity in GraphQL, no getUser)#233
Progi1984 merged 3 commits into
PrestaShop:masterfrom
PrestaEdit:feat/full-population-leaderboards

Conversation

@PrestaEdit

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #232. Makes the reviewers / issues / pull-requests leaderboards cover every contributor (committers and non-committers) while staying sustainable on GitHub Actions (ephemeral runners, no persistent cache, 5000 req/h).

  • Identity captured in the GraphQL fetchfetch:issues and fetch:pullrequests:all now select author { login avatarUrl url ... on User { name } } (and the same on each review author), so downstream needs no per-user REST call.
  • generate:topstats builds a login → {name, avatar_url, html_url} map from the fetched files (buildIdentities()), resolves identity from contributors_prs.json → that map → a minimal fallback, and no longer calls getUser at all.
  • Cap removed — the three ranking files now contain everyone with count ≥ 1 (the front keeps a Top-50 highlight and shows the full lists in the Wall of Fame).

Reviews still count distinct PRs (self-reviews excluded, counted even on deleted-author PRs); issues exclude PRs; null authors are skipped for authored counts. contributors_prs.json enrichment is unchanged.

Pairs with PrestaShop/TopContributors#231 (front: Top-50 + Wall-of-Fame tabs).

Test Plan

  • phpstan analyse[OK] No errors
  • php-cs-fixer — no diff
  • Offline aggregation + identity-map assertion passes (distinct-PR reviews, self-review excluded, null-author handling, fallback identity)
  • Live make generate on CI produces full-population top_*.json with zero getUser calls

🤖 Generated with Claude Code

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jul 1, 2026
@Progi1984
Progi1984 merged commit 813075e into PrestaShop:master Jul 1, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Merged in PR Dashboard Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants