Skip to content

feat: full-population reviewers/issues/PR ranking (identity in GraphQL, no getUser) #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Progi1984 merged 3 commits into from
Jul 1, 2026
Merged

feat: full-population reviewers/issues/PR ranking (identity in GraphQL, no getUser) #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7fd663
feat: capture issue author identity in fetch:issues
PrestaEdit Jul 1, 2026
594d350
feat: capture PR author + reviewer identity in fetch:pullrequests:all
PrestaEdit Jul 1, 2026
7925e07
feat: full-population ranking from fetched identity, no getUser
PrestaEdit Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Command/FetchIssuesCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ protected function fetchOrgIssues(): void
number
author {
login
avatarUrl
url
... on User {
name
}
}
repository {
name
Expand All @@ -91,9 +96,13 @@ protected function fetchOrgIssues(): void
$issuesCount += count($nodes);

foreach ($nodes as $node) {
$author = $node['author'] ?? null;
$issues[] = [
'number' => $node['number'],
'login' => $node['author']['login'] ?? null,
'login' => $author['login'] ?? null,
'name' => $author['name'] ?? null,
'avatar_url' => $author['avatarUrl'] ?? null,
'html_url' => $author['url'] ?? null,
'repository' => $node['repository']['name'],
];
}
Expand Down
30 changes: 25 additions & 5 deletions src/Command/FetchPullRequestsAllCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,21 @@ protected function fetchOrgPullRequests(): void
number
author {
login
avatarUrl
url
... on User {
name
}
}
reviews(first: 100) {
nodes {
author {
login
avatarUrl
url
... on User {
name
}
}
}
}
Expand All @@ -97,15 +107,25 @@ protected function fetchOrgPullRequests(): void
foreach ($nodes as $node) {
$reviewers = [];
foreach ($node['reviews']['nodes'] as $review) {
$reviewerLogin = $review['author']['login'] ?? null;
if ($reviewerLogin !== null) {
$reviewers[$reviewerLogin] = true;
$reviewer = $review['author'] ?? null;
$reviewerLogin = $reviewer['login'] ?? null;
if ($reviewerLogin !== null && !isset($reviewers[$reviewerLogin])) {
$reviewers[$reviewerLogin] = [
'login' => $reviewerLogin,
'name' => $reviewer['name'] ?? null,
'avatar_url' => $reviewer['avatarUrl'] ?? null,
'html_url' => $reviewer['url'] ?? null,
];
}
}
$author = $node['author'] ?? null;
$pullRequests[] = [
'number' => $node['number'],
'login' => $node['author']['login'] ?? null,
'reviewers' => array_keys($reviewers),
'login' => $author['login'] ?? null,
'name' => $author['name'] ?? null,
'avatar_url' => $author['avatarUrl'] ?? null,
'html_url' => $author['url'] ?? null,
'reviewers' => array_values($reviewers),
];
}

Expand Down
94 changes: 62 additions & 32 deletions src/Command/GenerateTopStatsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,9 @@
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Throwable;

class GenerateTopStatsCommand extends AbstractCommand
{
private const TOP_N = 25;

protected function configure(): void
{
$this->setName('traces:generate:topstats')
Expand All @@ -27,6 +24,10 @@ protected function configure(): void

protected function execute(InputInterface $input, OutputInterface $output): int
{
// This command makes no GitHub API call: identity comes from the fetched
// files. The --ghtoken option is kept only for pipeline compatibility
// (Makefile / gh-pages.yml pass it); parent::execute() still sets up an
// unused Github client.
parent::execute($input, $output);

// contributors_prs.json is produced by traces:generate:topcompanies, so this
Expand All @@ -45,30 +46,31 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$this->fetchConfiguration($input->getOption('config'));

/** @var array<array{number:int, login:string|null, reviewers:array<string>}> $pullRequests */
/** @var array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, reviewers:array<array{login:string, name:string|null, avatar_url:string|null, html_url:string|null}>}> $pullRequests */
$pullRequests = json_decode(file_get_contents(self::FILE_PULLREQUESTS_ALL) ?: '', true);
/** @var array<array{number:int, login:string|null, repository:string}> $issues */
/** @var array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, repository:string}> $issues */
$issues = json_decode(file_get_contents(self::FILE_ISSUES) ?: '', true);
/** @var array<string, mixed> $contributors */
$contributors = json_decode(file_get_contents(self::FILE_CONTRIBUTORS_PRS) ?: '', true);

$identities = $this->buildIdentities($pullRequests, $issues);
$aggregate = $this->aggregate($pullRequests, $issues);

$this->enrichContributors($contributors, $aggregate);
file_put_contents(self::FILE_CONTRIBUTORS_PRS, json_encode($contributors, JSON_PRETTY_PRINT));

file_put_contents(self::FILE_TOP_REVIEWERS, json_encode($this->buildRanking($aggregate['reviews'], $contributors), JSON_PRETTY_PRINT));
file_put_contents(self::FILE_TOP_ISSUES, json_encode($this->buildRanking($aggregate['issuesOpened'], $contributors), JSON_PRETTY_PRINT));
file_put_contents(self::FILE_TOP_PULLREQUESTS, json_encode($this->buildRanking($aggregate['pullRequestsOpened'], $contributors), JSON_PRETTY_PRINT));
file_put_contents(self::FILE_TOP_REVIEWERS, json_encode($this->buildRanking($aggregate['reviews'], $contributors, $identities), JSON_PRETTY_PRINT));
file_put_contents(self::FILE_TOP_ISSUES, json_encode($this->buildRanking($aggregate['issuesOpened'], $contributors, $identities), JSON_PRETTY_PRINT));
file_put_contents(self::FILE_TOP_PULLREQUESTS, json_encode($this->buildRanking($aggregate['pullRequestsOpened'], $contributors, $identities), JSON_PRETTY_PRINT));

$this->output->writeLn(['', 'Top stats generated.']);

return 0;
}

/**
* @param array<array{number:int, login:string|null, reviewers:array<string>}> $pullRequests
* @param array<array{number:int, login:string|null, repository:string}> $issues
* @param array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, reviewers:array<array{login:string, name:string|null, avatar_url:string|null, html_url:string|null}>}> $pullRequests
* @param array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, repository:string}> $issues
*
* @return array{reviews: array<string,int>, issuesOpened: array<string,int>, pullRequestsOpened: array<string,int>}
*/
Expand All @@ -86,10 +88,11 @@ public function aggregate(array $pullRequests, array $issues): array
// A review counts for its reviewer regardless of the PR author (even a
// deleted/null author) — only self-reviews are excluded.
foreach ($pullRequest['reviewers'] as $reviewer) {
if ($reviewer === $author) {
$reviewerLogin = $reviewer['login'];
if ($reviewerLogin === $author) {
continue;
}
$reviews[$reviewer] = ($reviews[$reviewer] ?? 0) + 1;
$reviews[$reviewerLogin] = ($reviews[$reviewerLogin] ?? 0) + 1;
}
}

Expand All @@ -107,6 +110,39 @@ public function aggregate(array $pullRequests, array $issues): array
];
}

/**
* @param array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, reviewers:array<array{login:string, name:string|null, avatar_url:string|null, html_url:string|null}>}> $pullRequests
* @param array<array{number:int, login:string|null, name:string|null, avatar_url:string|null, html_url:string|null, repository:string}> $issues
*
* @return array<string, array{name:string, avatar_url:string, html_url:string}>
*/
public function buildIdentities(array $pullRequests, array $issues): array
{
$identities = [];
$add = function (?string $login, ?string $name, ?string $avatarUrl, ?string $url) use (&$identities): void {
if ($login === null || isset($identities[$login])) {
return;
}
$identities[$login] = [
'name' => $name ?? $login,
'avatar_url' => $avatarUrl ?? '',
'html_url' => $url ?? 'https://github.com/' . $login,
];
};

foreach ($pullRequests as $pullRequest) {
$add($pullRequest['login'] ?? null, $pullRequest['name'] ?? null, $pullRequest['avatar_url'] ?? null, $pullRequest['html_url'] ?? null);
foreach ($pullRequest['reviewers'] as $reviewer) {
$add($reviewer['login'], $reviewer['name'] ?? null, $reviewer['avatar_url'] ?? null, $reviewer['html_url'] ?? null);
}
}
foreach ($issues as $issue) {
$add($issue['login'] ?? null, $issue['name'] ?? null, $issue['avatar_url'] ?? null, $issue['html_url'] ?? null);
}

return $identities;
}

/**
* @param array<string, mixed> $contributors
* @param array{reviews: array<string,int>, issuesOpened: array<string,int>, pullRequestsOpened: array<string,int>} $aggregate
Expand All @@ -127,10 +163,11 @@ private function enrichContributors(array &$contributors, array $aggregate): voi
/**
* @param array<string,int> $counts
* @param array<string, mixed> $contributors
* @param array<string, array{name:string, avatar_url:string, html_url:string}> $identities
*
* @return array{updatedAt: string, items: array<array{rank:int, login:string, name:string, avatar_url:string, html_url:string, count:int}>}
*/
private function buildRanking(array $counts, array $contributors): array
private function buildRanking(array $counts, array $contributors, array $identities): array
{
$logins = array_keys($counts);
usort($logins, function (string $a, string $b) use ($counts): int {
Expand All @@ -146,7 +183,7 @@ private function buildRanking(array $counts, array $contributors): array
if (!$this->configKeepExcludedUsers && in_array($login, $this->configExclusions, true)) {
continue;
}
$identity = $this->resolveIdentity($login, $contributors);
$identity = $this->resolveIdentity($login, $contributors, $identities);
$items[] = [
'rank' => $rank,
'login' => $login,
Expand All @@ -155,20 +192,19 @@ private function buildRanking(array $counts, array $contributors): array
'html_url' => $identity['html_url'],
'count' => $counts[$login],
];
if (++$rank > self::TOP_N) {
break;
}
++$rank;
}

return ['updatedAt' => date('Y-m-d'), 'items' => $items];
}

/**
* @param array<string, mixed> $contributors
* @param array<string, array{name:string, avatar_url:string, html_url:string}> $identities
*
* @return array{name:string, avatar_url:string, html_url:string}
*/
private function resolveIdentity(string $login, array $contributors): array
private function resolveIdentity(string $login, array $contributors, array $identities): array
{
if (isset($contributors[$login]) && is_array($contributors[$login])) {
$record = $contributors[$login];
Expand All @@ -180,20 +216,14 @@ private function resolveIdentity(string $login, array $contributors): array
];
}

try {
$user = $this->github->getUser($login);

return [
'name' => (string) ($user['name'] ?? $login),
'avatar_url' => (string) ($user['avatar_url'] ?? ''),
'html_url' => (string) ($user['html_url'] ?? 'https://github.com/' . $login),
];
} catch (Throwable) {
return [
'name' => $login,
'avatar_url' => '',
'html_url' => 'https://github.com/' . $login,
];
if (isset($identities[$login])) {
return $identities[$login];
}

return [
'name' => $login,
'avatar_url' => '',
'html_url' => 'https://github.com/' . $login,
];
}
}