feat(embeddings): add native MLX executor - #12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53662ff804
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| model_revision: std::env::var("LOCAL_EMBEDDING_MODEL_REVISION") | ||
| .unwrap_or_else(|_| "main".to_string()), |
There was a problem hiding this comment.
Use the configured revision when downloading Candle models
When LOCAL_EMBEDDING_MODEL_REVISION is unset, Config::from_env and the readiness handshake claim the pinned default revision, but this separate fallback causes Candle to download mutable main. The parity script supplies the revision explicitly, so it does not cover this default path; if upstream main advances, a deployment can generate incompatible embeddings while reporting that it uses the pinned model. Pass the configured revision into CandleEmbeddings or use the same default here.
Useful? React with 👍 / 👎.
Summary
Local validation
Commit 53662ff is SSH-signed.