chore: drop the preview-base override the reusable workflow now computes - #9
Merged
Merged
Conversation
The default was `https://codes.sota-shimozono.com`, which resolves to `sinkhole.paloaltonetworks.com`, so this repository passed the right base by hand. QAtlasHub/.github#26 made the default ask the Pages API where the site actually is, which for this repository answers `https://qatlashub.github.io/templateHPC.jl/` — the same value this line was supplying. The preview comment on this pull request is the check: it should read `https://qatlashub.github.io/templateHPC.jl/previews/PR<N>/` with the override gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
📚 Docs preview: https://qatlashub.github.io/templateHPC.jl/previews/PR9/ (updates on each push to this PR) |
A re-run reuses the reusable workflow at the ref the original run resolved, so it cannot pick up QAtlasHub/.github#27. A new event can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QAtlasHub/.github#26 made
docs-preview.ymlask the Pages API where the site is instead of defaulting tohttps://codes.sota-shimozono.com— a name that resolves tosinkhole.paloaltonetworks.com.This repository was passing
preview-base: 'https://qatlashub.github.io'by hand to work around that. The computed default now produces the same value, so the line says nothing the default does not.The preview comment on this pull request is the check. With the override gone it should read
https://qatlashub.github.io/templateHPC.jl/previews/PR<N>/.🤖 Generated with Claude Code