feat!: Promote control and dagger modifiers from experimental

guppylang-internals/src/guppylang_internals/cfg/builder.py

@@ -29,7 +29,7 @@
 from guppylang_internals.error import GuppyError, InternalGuppyError
 from guppylang_internals.experimental import (
     check_lists_enabled,
-    check_modifiers_enabled,
+    check_power_modifier_enabled,
 )
 from guppylang_internals.nodes import (
     ComptimeExpr,
@@ -348,7 +348,6 @@ def visit_FunctionDef(
         return bb
 
     def visit_With(self, node: ast.With, bb: BB, jumps: Jumps) -> BB | None:
-        check_modifiers_enabled(node)
         self._validate_modified_block(node)
 
         # Build context expressions and extract modifiers before constructing the inner
@@ -404,6 +403,7 @@ def _handle_withitem(self, node: ast.withitem) -> Modifier:
                     raise GuppyError(WrongNumberOfArgsError(span, 1, len(e.args)))
                 modifier = Control(e, e.args)
             case ast.Call(func=ast.Name(id="power")):
+                check_power_modifier_enabled(e.func)
                 if len(e.args) == 0:
                     span = Span(to_span(e.func).end, to_span(e).end)
                     raise GuppyError(WrongNumberOfArgsError(span, 1, len(e.args)))

guppylang-internals/src/guppylang_internals/experimental.py

@@ -76,11 +76,8 @@ def check_capturing_closures_enabled(loc: AstNode | None = None) -> None:
         raise GuppyError(UnsupportedError(loc, "Capturing closures"))
 
 
-def check_modifiers_enabled(loc: AstNode | None = None) -> None:
+def check_power_modifier_enabled(loc: AstNode | None = None) -> None:
     if not EXPERIMENTAL_FEATURES_ENABLED:
-        raise GuppyError(ExperimentalFeatureError(loc, "Modifiers"))
-
-
-def check_unitary_callable_enabled(thing: str, loc: AstNode | None = None) -> None:
-    if not EXPERIMENTAL_FEATURES_ENABLED:
-        raise GuppyError(ExperimentalFeatureError(loc, thing, singular_things=True))
+        raise GuppyError(
+            ExperimentalFeatureError(loc, "`power` modifier", singular_things=True)
+        )

guppylang-internals/src/guppylang_internals/tys/parsing.py

@@ -19,7 +19,6 @@
 from guppylang_internals.diagnostic import Error
 from guppylang_internals.engine import ENGINE
 from guppylang_internals.error import GuppyError
-from guppylang_internals.experimental import check_unitary_callable_enabled
 from guppylang_internals.tys.arg import Argument, ConstArg, TypeArg
 from guppylang_internals.tys.builtin import (
     CallableTypeDef,
@@ -205,8 +204,6 @@ def _arg_from_instantiated_defn(
     match defn:
         # Special cases for the `Callable` type
         case CallableTypeDef(flags=flags):
-            if flags != UnitaryFlags.NoFlags:
-                check_unitary_callable_enabled(flags.callable_name(), node)
             return TypeArg(_parse_callable_type(arg_nodes, node, ctx, flags=flags))
         # Special case for the `Self` type
         case SelfTypeDef():

tests/error/experimental_errors/modifier.err → tests/error/experimental_errors/power_modifier.err

@@ -1,11 +1,9 @@
-Error: Experimental feature (at $FILE:6:4)
+Error: Experimental feature (at $FILE:7:9)
   | 
-4 | @guppy
-5 | def main() -> None:
-6 |     with dagger:
-  |     ^^^^^^^^^^^^
-7 |         pass
-  | ^^^^^^^^^^^^ Modifiers are an experimental feature
+5 | @guppy
+6 | def main() -> None:
+7 |     with power(2):
+  |          ^^^^^ `power` modifier is an experimental feature
 
 Help: Experimental features are currently disabled. You can enable them by
 calling `guppylang.enable_experimental_features()`, however note that these

tests/error/experimental_errors/modifier.py → tests/error/experimental_errors/power_modifier.py

@@ -1,9 +1,10 @@
 from guppylang.decorator import guppy
+from guppylang.std.builtins import power
 
 
 @guppy
 def main() -> None:
-    with dagger:
+    with power(2):
         pass