feat!: Promote control and dagger modifiers from experimental#1881
Open
nicolaassolini-qntm wants to merge 2 commits into
Open
feat!: Promote control and dagger modifiers from experimental#1881nicolaassolini-qntm wants to merge 2 commits into
control and dagger modifiers from experimental#1881nicolaassolini-qntm wants to merge 2 commits into
Conversation
Contributor
|
| Branch | na/1789-control-and-dagger-non-experimental |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 154.02 x 1e3(0.00%)Baseline: 154.02 x 1e3 | 155.56 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 6,630.00(0.00%)Baseline: 6,630.00 | 6,696.30 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 27.71 x 1e3(0.00%)Baseline: 27.71 x 1e3 | 27.99 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1,051.00(0.00%)Baseline: 1,051.00 | 1,061.51 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 10.09 x 1e3(+0.01%)Baseline: 10.09 x 1e3 | 10.19 x 1e3 (99.02%) | 📈 view plot 🚷 view threshold | 301.00(0.00%)Baseline: 301.00 | 304.01 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 13.70 x 1e3(0.00%)Baseline: 13.70 x 1e3 | 13.83 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 420.00(0.00%)Baseline: 420.00 | 424.20 (99.01%) |
Collaborator
|
This PR contains breaking changes to the public Python API. Breaking changes summary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.01%
==========================================
Files 148 148
Lines 13849 13843 -6
==========================================
- Hits 12859 12853 -6
Misses 990 990 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
control and dagger no more experimentalcontrol and dagger no more experimental
control and dagger no more experimentalcontrol and dagger modifiers from experimental
…agger-non-experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1789
Now only
poweris experimentalBREAKING CHANGE: (
guppylang_internals/experimental.py)check_modifiers_enabledrenamed incheck_power_modifier_enabledBREAKING CHANGE: (
guppylang_internals/experimental.py)check_unitary_callable_enabledremoved