Skip to content

feat!: Promote control and dagger modifiers from experimental#1881

Open
nicolaassolini-qntm wants to merge 2 commits into
mainfrom
na/1789-control-and-dagger-non-experimental
Open

feat!: Promote control and dagger modifiers from experimental#1881
nicolaassolini-qntm wants to merge 2 commits into
mainfrom
na/1789-control-and-dagger-non-experimental

Conversation

@nicolaassolini-qntm

@nicolaassolini-qntm nicolaassolini-qntm commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

closes #1789

Now only power is experimental

BREAKING CHANGE: (guppylang_internals/experimental.py) check_modifiers_enabled renamed in check_power_modifier_enabled
BREAKING CHANGE: (guppylang_internals/experimental.py) check_unitary_callable_enabled removed

@nicolaassolini-qntm nicolaassolini-qntm linked an issue Jun 17, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchna/1789-control-and-dagger-non-experimental
TestbedLinux
Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes
(Result Δ%)
Upper Boundary
nodes
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
154.02 x 1e3
(0.00%)Baseline: 154.02 x 1e3
155.56 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
6,630.00
(0.00%)Baseline: 6,630.00
6,696.30
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
27.71 x 1e3
(0.00%)Baseline: 27.71 x 1e3
27.99 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
1,051.00
(0.00%)Baseline: 1,051.00
1,061.51
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile📈 view plot
🚷 view threshold
10.09 x 1e3
(+0.01%)Baseline: 10.09 x 1e3
10.19 x 1e3
(99.02%)
📈 view plot
🚷 view threshold
301.00
(0.00%)Baseline: 301.00
304.01
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile📈 view plot
🚷 view threshold
13.70 x 1e3
(0.00%)Baseline: 13.70 x 1e3
13.83 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
420.00
(0.00%)Baseline: 420.00
424.20
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@hugrbot

hugrbot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This PR contains breaking changes to the public Python API.

Breaking changes summary
guppylang-internals/src/guppylang_internals/experimental.py:0: check_modifiers_enabled:
Public object was removed

guppylang-internals/src/guppylang_internals/experimental.py:0: check_unitary_callable_enabled:
Public object was removed


@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (3c19192) to head (9441dea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   92.85%   92.84%   -0.01%     
==========================================
  Files         148      148              
  Lines       13849    13843       -6     
==========================================
- Hits        12859    12853       -6     
  Misses        990      990              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicolaassolini-qntm nicolaassolini-qntm changed the title feat: Make control and dagger no more experimental feat!: Make control and dagger no more experimental Jun 17, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing na/1789-control-and-dagger-non-experimental (9441dea) with main (3c19192)

Open in CodSpeed

@maximilianruesch maximilianruesch changed the title feat!: Make control and dagger no more experimental feat!: Promote control and dagger modifiers from experimental Jun 17, 2026
@nicolaassolini-qntm nicolaassolini-qntm marked this pull request as ready for review June 19, 2026 12:42
@nicolaassolini-qntm nicolaassolini-qntm requested a review from a team as a code owner June 19, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Make control and dagger non-experimental

3 participants