Draft: Fix s,v,sdag,vdag signs#35
Closed
keefehuang wants to merge 1 commit into
Closed
Conversation
keefehuang
changed the title
Aerylia
reviewed
Aug 31, 2025
Aerylia
left a comment
Aerylia
left a comment
Contributor
There was a problem hiding this comment.
seems ok. Maybe let a 3rd person double check the signs cause I suck at those too
Contributor
|
Conclusion from todays meeting: the old code seems correct - needs double check. The issue that @Ectras found was that pushing an S through a Rx does not flip the sign even though it should. See figure 4 in https://arxiv.org/pdf/1906.01734 |
Contributor
|
Fix not needed, signs were correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.