Skip to content

Draft: Fix s,v,sdag,vdag signs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keefehuang wants to merge 1 commit into from
Closed

Draft: Fix s,v,sdag,vdag signs #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions src/data_structures/clifford_tableau.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,22 +274,22 @@ impl PropagateClifford for CliffordTableau {

fn s(&mut self, target: IndexType) -> &mut Self {
let chains_target = self.pauli_columns.get_mut(target).unwrap();
// Verified: SXS^dag = Y
// SYS^dag = -X
// Verified: SXS^dag = -Y
// SYS^dag = X
// SZS^dag = Z
self.signs ^= chains_target.y_bitmask();
// Defined for Phase gate in https://arxiv.org/pdf/quant-ph/0406196
chains_target.s();
self.signs ^= chains_target.y_bitmask();
self
}

fn v(&mut self, target: IndexType) -> &mut Self {
let chains_target = self.pauli_columns.get_mut(target).unwrap();
// Verified: VXV^dag = X
// VYV^dag = Z
// VZV^dag = -Y
chains_target.v();
// VYV^dag = -Z
// VZV^dag = Y
self.signs ^= chains_target.y_bitmask();
chains_target.v();
self
}
}
Expand Down Expand Up @@ -437,10 +437,10 @@ mod tests {
let ct_size = 3;
let mut ct = setup_sample_ct();

// Apply S on qubit 0
// Apply S on qubit 0 and 1
ct.s(0);

// Stab: ZZZ, -(-X)IY, IXY
// Stab: ZZZ, -XIY, IXY
// Destab: -IXI, ZII, ZIZ

// qubit 1x: ZXI
Expand All @@ -461,7 +461,7 @@ mod tests {
let x_3 = bitvec![0, 1, 1, 0, 0, 0];
let pauli_3_ref = PauliString::new(x_3, z_3);

let signs_ref = bitvec![0, 0, 0, 1, 0, 0];
let signs_ref = bitvec![0, 1, 0, 1, 0, 0];

let clifford_tableau_ref = CliffordTableau {
pauli_columns: vec![pauli_1_ref, pauli_2_ref, pauli_3_ref],
Expand All @@ -482,8 +482,8 @@ mod tests {
// Apply V on qubit 0
ct.v(0);

// Stab: (-Y)ZZ, -ZIY, IXY
// Destab: -IXI, (-Y)II, (-Y)IZ
// Stab: YZZ, -(-Z)IY, IXY
// Destab: -IXI, YII, YIZ

// qubit 1x: YZI
// qubit 1z: IYY
Expand All @@ -503,7 +503,7 @@ mod tests {
let x_3 = bitvec![0, 1, 1, 0, 0, 0];
let pauli_3_ref = PauliString::new(x_3, z_3);

let signs_ref = bitvec![1, 1, 0, 1, 1, 1];
let signs_ref = bitvec![0, 0, 0, 1, 0, 0];
let clifford_tableau_ref = CliffordTableau {
pauli_columns: vec![pauli_1_ref, pauli_2_ref, pauli_3_ref],
signs: signs_ref,
Expand All @@ -524,8 +524,8 @@ mod tests {
ct.s_dgr(0);
ct.s_dgr(1);

// Stab: ZZZ, -XIY, I(-Y)Y
// Destab: -I(-Y)I, ZII, ZIZ
// Stab: ZZZ, -(-X)IY, IYY
// Destab: -IYI, ZII, ZIZ

// qubit 1x: ZXI
// qubit 1z: IZZ
Expand All @@ -545,7 +545,7 @@ mod tests {
let x_3 = bitvec![0, 1, 1, 0, 0, 0];
let pauli_3_ref = PauliString::new(x_3, z_3);

let signs_ref = bitvec![0, 1, 1, 0, 0, 0];
let signs_ref = bitvec![0, 0, 0, 1, 0, 0];

let clifford_tableau_ref = CliffordTableau {
pauli_columns: vec![pauli_1_ref, pauli_2_ref, pauli_3_ref],
Expand All @@ -567,8 +567,8 @@ mod tests {
ct.v_dgr(0);
ct.v_dgr(1);

// Stab: YYZ, -(-Z)IY, IXY
// Destab: -IXI, YII, YIZ
// Stab: (-Y)(-Y)Z, -ZIY, IXY
// Destab: -IXI, (-Y)II, (-Y)IZ

// qubit 1x: YZI
// qubit 1z: IYY
Expand All @@ -588,7 +588,7 @@ mod tests {
let x_3 = bitvec![0, 1, 1, 0, 0, 0];
let pauli_3_ref = PauliString::new(x_3, z_3);

let signs_ref = bitvec![0, 0, 0, 1, 0, 0];
let signs_ref = bitvec![0, 1, 0, 1, 1, 1];

let clifford_tableau_ref = CliffordTableau {
pauli_columns: vec![pauli_1_ref, pauli_2_ref, pauli_3_ref],
Expand Down Expand Up @@ -638,6 +638,8 @@ mod tests {
size: ct_size,
};

println!("{}", clifford_tableau_ref);
println!("{}", ct);
assert_eq!(clifford_tableau_ref, ct);
}

Expand Down
Loading