Fix ordering of dependent qube actions - #499
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 76.85% 76.86%
=======================================
Files 53 53
Lines 9436 9457 +21
=======================================
+ Hits 7252 7269 +17
- Misses 2184 2188 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I don't like this, it makes the common case execute yet another requests (to check the power state), which |
3eb52b5 to
dd080ea
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082719-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 37 fixed
Unstable testsDetails
Performance TestsPerformance degradation:20 performance degradations
Remaining performance tests:91 tests
|
|
Looks good now, but can you squash the commits together? |
|
Yes sure. Is this something you always would like me to do? In the repo I maintain I just always use the button that github provides to do that |
|
Generally yes, unless there are indeed multiple separate changes in a single PR. Theoretically, I could do that myself, but it would invalidate commit signature, which I'd like to preserve. |
dd080ea to
0ba42cd
Compare
3 participants
Summary
Addresses the qvm-start portion of QubesOS/qubes-issues#10860.
When multiple qubes are requested, dependency auto-starts can change another requested qube's state before its concurrent start task checks it, causing a false "Domain is already running" error.
This change:
--skip-if-runningis used;qvm-shutdownis intentionally unchanged. Its dependency checks occur server-side and cover audiovm, guivm, netvm, and assigned devices, so a client-side NetVM-only ordering fix would be incomplete.Testing
python -m compileall -q qubesadmingit diff --checkAI assistance disclosure
This change was developed with assistance from OpenAI Codex. I reviewed and adapted the implementation and ran the test suite.