Templates: open URLs in disposables - #665
notmuchtohide wants to merge 6 commits into
Conversation
This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables. This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983). Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online. Service ConditionGroup borrowed from qubes-notification-agent.
|
I'm not sure if this makes sense here, opening all urls in a template in disposables makes I think a lot of sense and is more resilient to other package managers using packagekit or whatnot.
agreed on that |
|
Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 3 3
Lines 502 502
=======================================
Hits 358 358
Misses 144 144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
multi-user is a system target and not a user target.
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026091612-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:No issues Remaining performance tests:71 tests
|
|
|
||
| # Systemd preload-all | ||
| preset_units /lib/systemd/system-preset/75-qubes-vm.preset initial | ||
| preset_units /usr/lib/systemd/user-preset/75-qubes-open-in-dispvm.preset initial --user |
There was a problem hiding this comment.
This should be --global option, --user does it only for the current user (which is root at package installation).
| installSerialConf | ||
| else | ||
| preset_units /lib/systemd/system-preset/75-qubes-vm.preset upgrade | ||
| preset_units /usr/lib/systemd/user-preset/75-qubes-open-in-dispvm.preset upgrade --user |
| if [ $1 -eq 1 ] | ||
| then | ||
| preset_units %{_presetdir}/%qubes_preset_file initial | ||
| preset_units %{_userpresetdir}/75-qubes-open-in-dispvm.preset initial --user |
| changed=true | ||
| else | ||
| preset_units %{_presetdir}/%qubes_preset_file upgrade | ||
| preset_units %{_userpresetdir}/75-qubes-open-in-dispvm.preset upgrade --user |
6a31b93 to
97388ba
Compare
| @@ -0,0 +1 @@ | |||
| enable open-urls-in-dispvm.service | |||
There was a problem hiding this comment.
Unfortunately this doesn't work on the package upgrade... I think you need to insert # Units below this line will be re-preset on package upgrade comment before (It's a magic text, script in rpm spec looks for it).
There was a problem hiding this comment.
Done, thanks!
97388ba to
119a78a
Compare
6 participants
This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables.
This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983).
Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online.
Note: On fedora-44-gnome, without this patch it may look like it already opens URLs in disposables, but that is because Firefox is not installed (QubesOS/qubes-issues#11023).
Service
ConditionGroupborrowed from qubes-notification-agent.