Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 71.71% 71.31% -0.40%
==========================================
Files 3 3
Lines 502 502
==========================================
- Hits 360 358 -2
- Misses 142 144 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026091612-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:No issues Remaining performance tests:71 tests
|
Add an is_templatevm check ahead of is_custom_persist_enabled so TemplateVMs always get the default mount_home=true / mount_usr_local=true behavior, regardless of custom-persist configuration. AppVM behavior is unchanged.
c2ef480 to
a89634a
Compare
|
CI failed due to reasons unrelated to the PR |
4 participants
Fixes QubesOS/qubes-issues/issues/11054
When
custom-persistisenabled on a TemplateVM with no paths persisted, the script falls through to
initialize_home "/home" unconditionallywith no mount in place, but aTemplateVM's root filesystem isn't discarded, so those writes land
permanently on the root volume and propagate to every AppVM based on that
template.
This adds an
is_templatevmcheck ahead of the existingis_custom_persist_enabledbranch, so TemplateVMs always get the defaultmount_home=true/mount_usr_local=truebehavior regardless ofcustom-persist configuration. AppVM behavior is unchanged.
Testing
Tested with a mocked harness (qubesdb calls, mount, initialize_home, and
related functions stubbed out) covering four cases:
default branch (previously took the buggy fallback)
takes the fallback branch
/homeexplicitly persisted → unchangedAI Disclosure
Used Claude to write test harness and check the fix before checking it myself.