waawvmupdate: run qubes.PostUpdate hook after every update attempt - #225
Conversation
|
PipelineRetry |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 71.36% 73.75% +2.38%
==========================================
Files 12 14 +2
Lines 1383 1440 +57
==========================================
+ Hits 987 1062 +75
+ Misses 396 378 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026091318-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:No issues Remaining performance tests:111 tests
|
4 participants
The dnf agents return before the transaction when there is nothing to upgrade, and apt-get never invokes dpkg (and so never
DPkg::Post-Invoke) when there is nothing to do. As a resultqubes.PostInstalland anypost-install.dscript only run after a real package change, and secondary package managers hooked there lag behind on quiet templates like debian minimal.After the package manager finishes with
OKorOK_NO_UPDATESin a template or standalone qube, the agent now runs/etc/qubes-rpc/qubes.PostUpdate, which executes/etc/qubes/post-update.d/*.shregardless of whether any package changed. The script itself ships with QubesOS/qubes-core-agent-linux#676. If it is missing, the template runs an older core-agent and the step is skipped.Fixes QubesOS/qubes-issues#10389.
AI disclosure: I used a local LLM for writing commit messages. I have written each line of code myself, but I used Claude Fable 5 to brainstorm an implementation plan and review my code. Fable also edited
doc/tools/qubes-vm-update.rstfor me.