Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Codex counted only nonempty
agentMessageitems as turns. Reasoning/tool-only responses could therefore exceed--max-turns, while multiple text items from one model response consumed multiple turns. The CLI also lacked the Dashboard's budget interruption.Count completed model responses from cumulative SDK usage updates, deduplicate repeated updates, and use the same recorder in CLI and Dashboard. Multiple tools or text items within one response count once. Request one interrupt at the limit, preserve an already recorded
finish, and retain normal SDK/MCP cleanup.turns_usednow reports completed model responses. Document the semantics in both languages.This is the independent fix for #190 (comment); RoboCasa memory changes remain in #190.
Validation
pytest tests/unit_tests -v -rs: 591 passed, 3 skipped. Skips require the optional RoboTwin/LeRobot dependencies.pre-commit run --all-files: passed.