rocfile: Throw system_error if IO failed in amdgpu#21
Merged
Conversation
kurtmcmillan
force-pushed
the
z/kumcmill/prefer-system-error-in-hip-io-funcs
branch
from
f80b2d1 to
92528b0
Compare
status will be set if IO fails in amdgpu/kfd. If status is set, throw a system_error instead of throwing HipRuntimeError.
kurtmcmillan
force-pushed
the
z/kumcmill/prefer-system-error-in-hip-io-funcs
branch
from
92528b0 to
e620ea1
Compare
kurtmcmillan
requested review from
derobins,
gaoikawa,
jordan-turbofish and
riley-dixon
as code owners
derobins
approved these changes
Nov 5, 2025
kurtmcmillan
deleted the
z/kumcmill/prefer-system-error-in-hip-io-funcs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.