Skip to content

rocfile: Throw system_error if IO failed in amdgpu #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derobins merged 1 commit into from
Nov 5, 2025
Merged

rocfile: Throw system_error if IO failed in amdgpu #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions rocfile/src/hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,20 @@ uint64_t
Hip::hipAmdFileRead(hipAmdFileHandle_t handle, void *devicePtr, uint64_t size, int64_t file_offset) const
{
static const hipAmdFileRead_t hipAmdFileReadPtr{getHipAmdFileReadPtr()};
uint64_t bytes_read;
int status;
uint64_t bytes_read{};
int status{};

if (!hipAmdFileReadPtr) {
throw Hip::SymbolNotFound("Could not find hipAmdFileRead()");
}

(void)throwOnHipError<Hip::RuntimeError>(
(*hipAmdFileReadPtr)(handle, devicePtr, size, file_offset, &bytes_read, &status));
auto hip_error{(*hipAmdFileReadPtr)(handle, devicePtr, size, file_offset, &bytes_read, &status)};

if (status) {
throw std::system_error(status, std::generic_category());
throw std::system_error(abs(status), std::generic_category());
}
else if (hip_error) {
throw Hip::RuntimeError(hip_error);
}

return bytes_read;
Expand All @@ -142,18 +144,20 @@ uint64_t
Hip::hipAmdFileWrite(hipAmdFileHandle_t handle, void *devicePtr, uint64_t size, int64_t file_offset) const
{
static const hipAmdFileWrite_t hipAmdFileWritePtr{getHipAmdFileWritePtr()};
uint64_t bytes_written;
int32_t status;
uint64_t bytes_written{};
int32_t status{};

if (!hipAmdFileWritePtr) {
throw Hip::SymbolNotFound("Could not find hipAmdFileWrite()");
}

(void)throwOnHipError<Hip::RuntimeError>(
(*hipAmdFileWritePtr)(handle, devicePtr, size, file_offset, &bytes_written, &status));
auto hip_error{(*hipAmdFileWritePtr)(handle, devicePtr, size, file_offset, &bytes_written, &status)};

if (status) {
throw std::system_error(status, std::generic_category());
throw std::system_error(abs(status), std::generic_category());
}
else if (hip_error) {
throw Hip::RuntimeError(hip_error);
}

return bytes_written;
Expand Down