Skip to content

Use C++ versions of C headers#220

Merged
derobins merged 2 commits into
developfrom
derobins/c++_c_headers
Mar 17, 2026
Merged

Use C++ versions of C headers#220
derobins merged 2 commits into
developfrom
derobins/c++_c_headers

Conversation

@derobins
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates system test sources to include the C++ <c*> wrapper headers instead of their C equivalents, aligning the test code with C++-style standard library includes.

Changes:

  • Replaced C headers with C++ wrapper headers in system tests (e.g., errno.hcerrno, string.hcstring).
  • Added some additional C++ wrapper headers in driver.cpp (climits, cstdint, ctime).
  • Updated config.cpp to use cstddef instead of stddef.h.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/system/driver.cpp Switches several C headers to C++ wrapper headers (<cerrno>, <climits>, <cstdint>, <ctime>).
test/system/config.cpp Replaces <stddef.h> with <cstddef>.
test/system/async.cpp Replaces <assert.h>/<string.h> with <cassert>/<cstring>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread test/system/async.cpp
Comment thread test/system/driver.cpp Outdated
@derobins derobins merged commit 88b004c into develop Mar 17, 2026
41 checks passed
@derobins derobins deleted the derobins/c++_c_headers branch March 17, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants