Skip to content

Use C++ versions of C headers #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derobins merged 2 commits into from
Mar 17, 2026
Merged

Use C++ versions of C headers #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de54844
Use C++ versions of C headers
derobins Mar 16, 2026
5e5e079
Address copilot comments
derobins Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/system/async.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@
#include "test-options.h"

#include <array>
#include <assert.h>
#include <cassert>
#include <cstdint>
#include <cstddef>
#include <cstring>
#include <fcntl.h>
Comment thread
derobins marked this conversation as resolved.
#include <gtest/gtest.h>
#include <hip/hip_runtime_api.h>
#include <memory>
#include <sstream>
#include <string>
#include <string.h>
#include <sys/types.h>
#include <tuple>
#include <variant>
Expand Down Expand Up @@ -98,7 +98,7 @@ assertMemoryRegionsMatch(void *mem1, hoff_t mem1_offset, void *mem2, hoff_t mem2
mem2_v = copyGpuMemory(mem2, mem2_offset, region_size);
mem2 = mem2_v.data();
}
assert(memcmp(mem1, mem2, region_size) == 0);
assert(std::memcmp(mem1, mem2, region_size) == 0);
}

static void
Expand Down
2 changes: 1 addition & 1 deletion test/system/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
#include "hipfile.h"
#include "test-common.h"

#include <cstddef>
#include <gtest/gtest.h>
#include <stddef.h>
#include <string>
#include <vector>

Expand Down
8 changes: 4 additions & 4 deletions test/system/driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
#include "test-options.h"
#include "test-shared-fixtures.h"

#include <errno.h>
#include <cerrno>
#include <climits>
#include <cstdint>
#include <gtest/gtest.h>
#include <hip/hip_runtime_api.h>
#include <limits.h>
#include <stdint.h>
#include <thread>
#include <time.h>
#include <time.h> // Do NOT convert to <ctime> as that is not guaranteed to have `struct timespec`
#include <vector>

#ifdef __HIP_PLATFORM_NVIDIA__
Expand Down
Loading