Match the tooltip guid to a group unit token when UnitTokenFromGUID returns nil

[KogasaPls]

Unit tooltips for a party or raid member resolve to no unit: the guid is readable, but UnitTokenFromGUID on it returns nil while the tooltip is being built, so OnTooltipSetUnit bails and no score is drawn. Tooltips anchored to target or focus are unaffected, since those tokens persist and resolve. This reaches any unit frame that shows group members, Blizzard's included. EllesmereUI already carries a Raider.IO-specific workaround in its raid frames that calls ShowProfile with a guid-matched token, but the fix belongs here so every frame gets it.

Use the guid directly when the unit token is secret or missing by comparing it to player, partyN, and raidN.

Tested with Grid2 raid frames on a 12.1.0 client: the score draws where it did not before. The nil token and readable UnitGUID results behind it were measured both in and out of instance combat.

[Vladinator]

I'll take a closer look soon.

I just tested a little during instance combat with default frames and noticed that the main GetTooltipUnit function doesn't get called when hovering party/raid frames during instance combat lockdown.

However, I do see that outside of combat the UnitTokenFromGUID can return nil when I expected it to always return a valid guid when not being restricted, so the suggested GetGroupUnitTokenFromGUID does help bridge that gap, as long it's outside of combat.

Did you also observe the same when you made the code?

[KogasaPls]

I had tested Grid2 (not vanilla frames) in an instance while out of combat only.

I just tested in combat and noticed:

• The UnitTokenFromGUID token is nil, not secret. The idea that they could be secret came from an EllesmereUI comment, I don't know if it's actually true so I've dropped it from the PR.
• The token is nil for party frames in instances regardless of combat state.
• UnitGUID("player") and UnitGUID("party1") both return plain guids in combat still so this method works in combat.

I've updated the PR slightly. The fix is the same.

[KogasaPls]

Also, I didn't check to see if GetTooltipUnit actually fires in combat, but I think it should if `showScoreInCombat = true`. If you have that on and it's not firing I'm not sure why.

…

On Wed, Sep 9, 2026, 17:35 Alex Pedersen ***@***.***> wrote: *Vladinator* left a comment (RaiderIO/raiderio-addon#394) <#394 (comment)> I'll take a closer look soon. I just tested a little during instance combat with default frames and noticed that the main GetTooltipUnit function doesn't get called when hovering party/raid frames during instance combat lockdown. However, I do see that outside of combat the UnitTokenFromGUID can return nil when I expected it to always return a valid guid when not being restricted, so the suggested GetGroupUnitTokenFromGUID does help bridge that gap, as long it's outside of combat. Did you also observe the same when you made the code? — Reply to this email directly, view it on GitHub <#394?email_source=notifications&email_token=AU3TMFMXTIRSW4BKZYWIRKT5OHEJVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRQHEYDMOBRHEY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5609068191>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU3TMFJG4PHMY7IDNZH7RXD5OHEJVAVCNFSNUABFKJSXA33TNF2G64TZHMYTANJVG44TMNBUHNEXG43VMU5TKNBQGI4TMOJWGQY2C5QC> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Vladinator]

I merged it in as it worked for the default UI as well, at least there were no issues to hover people during raid.

I tested both with the combat tooltip option enabled and disabled just to ensure there were no issues with the default UI raid frames.

Thanks for the suggestion, I wasn't aware that the UnitTokenFromGUID was so stingy considering you can then resolve it like this - which should have been part of the API itself since this is possible. 🤷

[Vladinator]

I've heard reports where the recent change ends up with their tooltips sometimes having double profiles.

I suspect it might be related to the initial statement:

EllesmereUI already carries a Raider.IO-specific workaround in its raid frames that calls ShowProfile with a guid-matched token, but the fix belongs here so every frame gets it.

So I suspect I must let @EllesmereGaming know so they can adjust their code if this is the case. As it should no longer be needed to do this action.

[KogasaPls]

Yeah, they show the RIO tooltip manually. I'll submit a PR now that it's no longer necessary

…

On Tue, Sep 15, 2026, 13:29 Alex Pedersen ***@***.***> wrote: *Vladinator* left a comment (RaiderIO/raiderio-addon#394) <#394 (comment)> I've heard reports where the recent change ends up with their tooltips sometimes having double profiles. I suspect it might be related to the initial statement: EllesmereUI already carries a Raider.IO-specific workaround in its raid frames that calls ShowProfile with a guid-matched token, but the fix belongs here so every frame gets it. So I suspect I must let @EllesmereGaming <https://github.com/EllesmereGaming> know so they can adjust their code if this is the case. As it should no longer be needed to do this action. — Reply to this email directly, view it on GitHub <#394?email_source=notifications&email_token=AU3TMFI5BQGWD4RCRRMTHUT5PF37ZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRYGQ4TEMBWGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5684920623>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU3TMFMIFG6Z2QRPMTSGAJT5PF37ZAVCNFSNUABFKJSXA33TNF2G64TZHMYTANJVG44TMNBUHNEXG43VMU5TKNBQGI4TMOJWGQY2C5QC> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[KogasaPls]

PR submitted: EllesmereGaming/EllesmereUI#2102

My mistake for not submitting the followup PR immediately after this was merged. Thank you for pointing it out.