Skip to content

Fix duplicate Raider.IO tooltips on raid frames - #2102

Open
KogasaPls wants to merge 1 commit into
EllesmereGaming:mainfrom
KogasaPls:fix/raid-frames-raiderio-duplicate-tooltip
Open

KogasaPls wants to merge 1 commit into
EllesmereGaming:mainfrom
KogasaPls:fix/raid-frames-raiderio-duplicate-tooltip

Conversation

@KogasaPls

Copy link
Copy Markdown
Contributor

What does this PR do?

Raider.IO now matches group units by GUID upstream (RaiderIO/raiderio-addon#394), which resolves tooltip units directly. The manual ShowProfile call in EllesmereUI is no longer necessary and caused tooltips to render twice.

How was it tested?

Verified syntax with luac -p and checked diff against upstream Raider.IO tooltip resolution.

Checklist

  • New settings default OFF (N/A, no new settings)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Raider.IO now matches group units by GUID upstream (RaiderIO/raiderio-addon#394), so manual profile drawing is no longer needed and caused duplicate tooltips.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant