Return {} for a response with no body instead of raising TypeError

[pcbeingused333]

The bug

Courrier::Email::Result and Courrier::Subscriber::Result both parse the response body like this:

def parse_body(body)
  return {} if @response.nil?

  begin
    JSON.parse(body)
  rescue JSON::ParserError
    {}
  end
end

The rescue only covers JSON::ParserError. When the response is present but its body is nil — 204 No Content from a subscriber destroy, or any provider that answers a success status with an empty payload — JSON.parse(nil) raises TypeError: no implicit conversion of nil into String, so Result.new raises on a request that actually succeeded.

response = Data.define(:code, :body).new(code: "204", body: nil)
Courrier::Email::Result.new(response: response)
# => TypeError: no implicit conversion of nil into String
Courrier::Subscriber::Result.new(response: response)
# => TypeError: no implicit conversion of nil into String

The fix

parse_body / parsed return {} for a nil or empty body before reaching JSON.parse. successful? is unchanged, so it falls through to the status code and a 204 is still reported as a success.

Tests

Added test_initialize_with_no_content_response (204, nil body) and test_initialize_with_empty_body to both result_test.rb files. The nil-body cases error on main and pass with the fix. bundle exec rake and bundle exec standardrb are green (163 runs, 0 failures).

🤖 Generated with Claude Code