Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/courrier/email/result.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def success? = @success
private

def parse_body(body)
return {} if @response.nil?
return {} if body.nil? || body.empty?

begin
JSON.parse(body)
Expand Down
2 changes: 1 addition & 1 deletion lib/courrier/subscriber/result.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def success? = @success
private

def parsed(body)
return {} if @response.nil?
return {} if body.nil? || body.empty?

begin
JSON.parse(body)
Expand Down
16 changes: 16 additions & 0 deletions test/courrier/email/result_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,22 @@ def test_initialize_with_error
assert_equal({}, result.data)
end

def test_initialize_with_no_content_response
response = Data.define(:code, :body).new(code: "204", body: nil)
result = Courrier::Email::Result.new(response: response)

assert result.success?
assert_equal({}, result.data)
end

def test_initialize_with_empty_body
response = Data.define(:code, :body).new(code: "202", body: "")
result = Courrier::Email::Result.new(response: response)

assert result.success?
assert_equal({}, result.data)
end

def test_success_predicate_method
result = Courrier::Email::Result.new(
response: Data.define(:code, :body).new(code: "200", body: "{}")
Expand Down
16 changes: 16 additions & 0 deletions test/courrier/subscriber/result_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ def test_initialize_with_error
assert_equal({}, result.data)
end

def test_initialize_with_no_content_response
response = Data.define(:code, :body).new(code: "204", body: nil)
result = Courrier::Subscriber::Result.new(response: response)

assert result.success?
assert_equal({}, result.data)
end

def test_initialize_with_empty_body
response = Data.define(:code, :body).new(code: "200", body: "")
result = Courrier::Subscriber::Result.new(response: response)

assert result.success?
assert_equal({}, result.data)
end

def test_success_predicate_method
result = Courrier::Subscriber::Result.new(
response: Data.define(:code, :body).new(code: "200", body: "{}")
Expand Down
Loading