This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
fix(ei-compare): keep team on character-swap split slices - #205
Merged
Merged
Conversation
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/parser-parity-after-190
branch
from
August 9, 2026 16:05
5ebf579 to
c47e0eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent EI-parity fixes reducing corpus deltas 190 -> 179.
Changes
1. EI compare — team on character-swap split slices
EI reports the original team on every slice when one account switches characters mid-fight (same instance_id/agent_id, new display name). Track known account names and apply the team when the account has more than one name or the slice is the last same-character slice.
libs/gw2_analytics/src/gw2_analytics/ei_compare.py+ 2 tests2. Rotation — expected duration for pending Resurrect casts
Resurrect (skill 1066) activations open with raw duration 700ms but the cast stays pending and EI reports the expected 800ms. Added to
_PENDING_EXPECTED_DURATION_SKILLS.libs/gw2_analytics/src/gw2_analytics/rotation.py+ 1 testVerification
uv run pytest libs/gw2_analytics/tests/test_rotation.py libs/gw2_analytics/tests/test_ei_compare.pyall passuv run ruff check/uv run ruff format --checkclean