Repository navigation
fix(buffUptimes): instance recycling for Non Squad Players - #227
Merged
Merged
Conversation
…recycling Non Squad Players (instance-recycled anonymous agents) were not getting their recycled aliases included in buff uptime calculation because player_agent_ids() was called without slice bounds, disabling the instance-recycling logic. Fix: pass slice_lo, slice_hi to player_agent_ids() so it can add other agents sharing the same instance_id whose awareness overlaps the slice window. Result: buffUptimes FAILs 175 -> 53 (-122, 70% reduction) on corpus. 20260118-020548 Non Squad Player buffs now match (0 diffs). Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffUptimes FAILs 175 -> 53 (-122, 70% reduction). Fixes Non Squad Player buff uptime by passing slice bounds to player_agent_ids().