Repository navigation
feat: migrate compare page from AG Grid to native HTML tables - #75
Merged
Merged
Conversation
- New CompareReadoutTable component with per-table independent sorting - Replaces 4 AG Grid components (PlayerReadoutDamage/Heal/Boons/Defense) - 14 GW2 boon icons in boon table headers (matching ReadoutTabClient) - onError graceful degradation on all icons Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
- New shared module with style constants, BOONS, useSortedPlayers, utility components - ReadoutTabClient imports from shared, passes ROLE_TOOLTIPS via IdentityCells prop - CompareReadoutTable imports from shared, no more duplication - Single source of truth: style/BOONS/sorting changes are now 1-file edits Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
…odule to lib/ - Deleted 6 dead AG Grid files (PlayerReadoutDamage/Heal/Boons/Defense/Grid/Base) + ag-grid-setup.ts restored (used by other grids) - Deleted 7 test files (player-readout-*.test.tsx, combat-readout.test.tsx, PlayerReadoutGrid.test.tsx, PlayerReadoutBase.test.tsx) - Updated setup.ts - removed 4 PlayerReadout mocks - Moved readoutTableParts.tsx from shared/ to lib/ for project convention consistency Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements
Migration de la page
/fights/comparedes tableaux AG Grid vers des tableaux HTML natifs, cohérents avecReadoutTabClient.Nouveau composant
CompareReadoutTable.tsx: Tableau HTML natif avec tri par colonne indépendantonErrorgraceful degradation sur toutes les icônesEliteSpecCellRenderer/CommanderCellRendererexistantsPage compare mise à jour
CompareReadoutTableCompareReadoutTableau lieu dePlayerReadoutDamage/Heal/Boons/DefenseValidation
Note dette technique
PlayerReadout*,PlayerReadoutGrid,PlayerReadoutBase) ne sont plus utilisés par la page compare mais peuvent encore être importés par les tests. Leur nettoyage peut être fait dans une PR suivante.