refactor: use _validate_elite_for_profession helper in _decode_agent - #78
Merged
Merged
Conversation
…ofession call - _decode_agent now calls the existing _validate_elite_for_profession helper instead of duplicating the validation inline (5 lines → 1 line). - This makes the legacy path consistent with _decode_agent_2025 which already uses the same helper. - Updated the stale comment that still referenced _LEGACY_ELITE_OVERRIDE. Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements
Dans
parser.py, le_decode_agent(legacy) utilisait une validationinline qui dupliquait exactement le helper
_validate_elite_for_professionexistant au niveau module.
_decode_agent_2025qui utilise déjà ce helper_LEGACY_ELITE_OVERRIDE)Validation