Skip to content

refactor: use _validate_elite_for_profession helper in _decode_agent #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roddygithub merged 1 commit into from
Jul 25, 2026
Merged

refactor: use _validate_elite_for_profession helper in _decode_agent #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions libs/gw2_evtc_parser/src/gw2_evtc_parser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,15 +1695,10 @@ def _decode_agent(data: bytes, offset: int) -> Agent:
except ValueError:
profession = Profession.UNKNOWN

# v0.16.3-api: map legacy elite ID via override, then validate
# against the profession. If the override fails validation, try
# the raw value (handles collision IDs 55 and 63 where the raw
# value IS the API ID for one profession).
valid_set = _VALID_ELITE_BY_PROFESSION.get(int(prof_raw))
if valid_set is not None and int(elite_raw) in valid_set:
elite = EliteSpec(int(elite_raw))
else:
elite = EliteSpec.BASE
# v0.16.3-api: cross-validate elite ID against the agent's
# profession using the canonical helper (handles shared
# collision IDs 55, 63, 73, 74, 75, 77).
elite = _validate_elite_for_profession(int(prof_raw), int(elite_raw))

return Agent(
id=aid,
Expand Down
Loading