Repository navigation
test: add fixture unit tests + cleanup redundant int() calls in parser.py - #79
Merged
Merged
Conversation
- web/tests/fixtures/playerReadoutRow.test.ts: 8 tests for buildPlayerReadoutRow (defaults, top-level overrides, nested overrides via spread pattern) - parser.py: removed redundant int() calls in _validate_elite_for_profession (prof_raw and elite_raw are already Python ints from struct unpack) Both _decode_agent_2025 and _decode_agent paths updated. Signed-off-by: RoddyGitHub <roddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements\n\n### Nouveau test\n- web/tests/fixtures/playerReadoutRow.test.ts : 8 tests pour buildPlayerReadoutRow\n (valeurs par défaut, overrides top-level, overrides nested via spread pattern)\n\n### Nettoyage parser.py\n- Suppression des appels redondants dans les deux appels à\n (lignes 1632 et 1701). et\n sont déjà des Python issus du struct.unpack.\n\n### Validation\n- TypeScript clean\n- 8/8 tests fixture passent\n- ruff lint + format OK\n- Tests Python OK