[Fix] Unsupported prompt attachments disappear without feedback - #2302
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Unsupported prompt attachments disappear without feedback#2302roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
This was referenced Sep 7, 2026
daniel-lxs
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue; maintainer-authorized bounded product investigation.
Why this PR exists
Unsupported attachments disappeared silently from the web composer. Selecting a mixed batch also silently omitted unsupported files, leaving users unsure which context would be included.
What changed
Show the existing attachment-validation error as a toast. Mixed batches now report that some file types were not added while preserving supported attachments. Prompt text, accepted types, extraction, submission and transport behavior are unchanged.
How it was tested
Base
d95a5fd045ff82f81d458256a6a871ec9cda611a; exact headd5415bb8928d5f4d68888ade0026c18a1ba80ff3.Real browser baseline on the authenticated home composer: choose a synthetic
.binfile and observe no chip or notification; choose.txtand observe its chip. A real mixed.txt/.binselection retained only the text file without explaining the omission. The initial fix showed the rejection toast on desktop and mobile, preserved the prompt, and allowed a supported file to be added afterward.Draft awaiting proof. The shared visual-proof window timed out before final-head mixed-batch proof. Earlier captures predate the mixed-batch change and are intentionally not presented as final screenshots. Capture and recovery stopped when the deadline was reached.
Resumable validation on this exact head: sign in to the local app, enter prompt text, select an unsupported
.bin, confirm the rejection toast and preserved text, then select.txtplus.bintogether and confirm one supported chip plus the partial-rejection toast. Remove/re-add the supported file and repeat at desktop and mobile widths. Capture the final-head states before marking the proof complete. No inference or task launch is needed for this admission-only claim.pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/web exec vitest run src/components/tasks/TaskPromptInput.client.test.tsx src/components/ai-elements/prompt-input.test.tsx 'src/app/(authenticated)/home/Home.client.test.tsx'.minthint).Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetFull pre-push static gates passed; the exact formatting-inclusive full lint and full tsc commands were not both run. No changeset added in this bounded fix.