Potential fix for code scanning alert no. 2: Uncontrolled command line#15
Merged
Rootless-Ghost merged 1 commit intomasterfrom Apr 25, 2026
Merged
Potential fix for code scanning alert no. 2: Uncontrolled command line#15Rootless-Ghost merged 1 commit intomasterfrom
Rootless-Ghost merged 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/2
To fix this without changing intended functionality, keep the allowlist gate but remove avoidable shell interpretation in
_build_commandforbash,sh, and non-Windowscmdfallback. Instead of["bash", "-c", command]/["sh", "-c", command], parse command into argv withshlex.split(command)and execute directly. This prevents shell metacharacter chaining from being interpreted as new commands.Best concrete change:
core/executor.py_build_command(...)(lines around 294–305 in snippet)-claunches for:cmdfallbackbashshshlex.split(command, posix=(platform.system().lower() != "windows")).ValueError) or command is empty, returnNonesoexecute()responds with unsupported/invalid command error path.No changes are required in
app.pyfor this specific sink hardening.Suggested fixes powered by Copilot Autofix. Review carefully before merging.