Skip to content

Potential fix for code scanning alert no. 2: Uncontrolled command line #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rootless-Ghost merged 1 commit into from
Apr 25, 2026
Merged

Potential fix for code scanning alert no. 2: Uncontrolled command line #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions core/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,14 +294,26 @@ def _build_command(command: str, executor_type: str) -> list[str] | None:
if executor_type == "cmd":
if system == "windows":
return ["cmd.exe", "/c", command]
# Fall back to sh on non-Windows
return ["sh", "-c", command]
# Fall back to direct execution on non-Windows (avoid shell -c)
try:
argv = shlex.split(command, posix=True)
except ValueError:
return None
return argv or None

if executor_type == "bash":
return ["bash", "-c", command]
try:
argv = shlex.split(command, posix=True)
except ValueError:
return None
return argv or None

if executor_type == "sh":
return ["sh", "-c", command]
try:
argv = shlex.split(command, posix=True)
except ValueError:
return None
return argv or None

return None

Expand Down
Loading