Skip to content

⚡ [performance] concurrent image fetching in discordService #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rukafuu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ [performance] concurrent image fetching in discordService #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Chat/backend/services/discordService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,22 +508,28 @@ class DiscordService {
if (!userMessage && message.attachments.size === 0) return;

// Handle Attachments (Vision)
const imageParts = [];
let imageParts = [];
if (message.attachments.size > 0) {
for (const [key, attachment] of message.attachments) {
if (attachment.contentType && attachment.contentType.startsWith('image/')) {
const downloadPromises = Array.from(message.attachments.values())
.filter(attachment => attachment.contentType && attachment.contentType.startsWith('image/'))
.map(async (attachment) => {
try {
const imageBase64 = await this.downloadAttachment(attachment.url);
imageParts.push({
return {
inlineData: {
mimeType: attachment.contentType,
data: imageBase64
}
});
};
} catch (err) {
console.error('Error downloading image:', err);
return null;
}
}
});

if (downloadPromises.length > 0) {
const results = await Promise.all(downloadPromises);
imageParts = results.filter(part => part !== null);
}
}

Expand Down