Clear previous Live2D models to prevent duplication - #35
Conversation
- Updated `PixiApp` and `Live2DModelType` interface definitions in `types.ts` (Chat and LiraCompanion) to include `removeChildren`, `removeChild`, `start`, `stop`, `resize`, and `visible`. - Implemented `this.app.stage.removeChildren()` in `loadModel` method within `liraCore.ts` (Chat and LiraCompanion) to clear previous models before adding a new one, including in the model reuse path. - Removed unnecessary `@ts-ignore` comments in `liraCore.ts` thanks to improved type definitions. - Added `this.app.stage.removeChildren()` to `LiraCompanion/liraLive2D.js` for consistency. - Verified that these changes resolve visual duplication and improve type safety. Co-authored-by: Rukafuu <111822334+Rukafuu@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This change ensures that previous Live2D models are properly cleared from the PixiJS stage before a new model is added, preventing visual duplication issues. I also took the opportunity to improve the TypeScript interface definitions for PixiJS and Live2D, which allowed me to remove several
@ts-ignorecomments and ensure better type safety throughout the avatar-related code. These improvements were applied to both the main Chat application and the Lira Companion application.PR created automatically by Jules for task 10550244626346655760 started by @Rukafuu