Skip to content

feat: support eslint 10#4439

Open
marufrasully wants to merge 12 commits intomainfrom
feat/support-eslint-10
Open

feat: support eslint 10#4439
marufrasully wants to merge 12 commits intomainfrom
feat/support-eslint-10

Conversation

@marufrasully
Copy link
Copy Markdown
Contributor

@marufrasully marufrasully commented Mar 19, 2026

This PR

  • migrate to ESlint 10
  • major version bump module @sap-ux/eslint-plugin-fiori-tools to 10
  • apply ESlint 10 for all non-React packages in the repo
  • following react packages remain on ESLint 9 due to eslint-plugin-react@7.37.5 incompatibility with ESLint 10
    • @sap-ux/ui-prompting-examples
    • @sap-ux/ui-components
    • @sap-ux/control-property-editor
    • @sap-ux/ui-prompting

Reason: eslint-plugin-react@7.37.5 uses deprecated ESLint APIs (specifically contextOrFilename.getFilename()) that were removed in ESLint 10.

@marufrasully marufrasully requested review from a team as code owners March 19, 2026 13:19
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: f6dd86b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@sap-ux/fe-fpm-cli Patch
@sap-ux/control-property-editor Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/eslint-plugin-fiori-tools Major
@sap-ux/app-config-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-test-writer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/create Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/repo-app-import-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marufrasully marufrasully mentioned this pull request Mar 19, 2026
@marufrasully marufrasully changed the title Feat/support eslint 10 feat: support eslint 10 Mar 19, 2026
@kranthie-sap kranthie-sap requested review from a team as code owners March 19, 2026 13:38
@marufrasully marufrasully requested review from a team as code owners March 19, 2026 15:01
@heimwege
Copy link
Copy Markdown
Contributor

heimwege commented Mar 19, 2026

@marufrasully
Copy link
Copy Markdown
Contributor Author

@marufrasully please also adjust the convert command at https://github.com/SAP/open-ux-tools/blob/main/packages/app-config-writer/src/eslint-config/convert.ts#L279

@heimwege thanks. Done in this d2b3f1f#diff-2dc1a16f21816f00c65858cf874323d6fa0d4077dfcb676cec3a62875b683da8R279

@sonarqubecloud
Copy link
Copy Markdown

"eslint": "^9",
"typescript-eslint": "^8.46.2",
"@types/semver": "7.7.1"
"eslint": "^10",
Copy link
Copy Markdown
Contributor

@heimwege heimwege Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marufrasully do we really need to be so strict or could we just say

Suggested change
"eslint": "^10",
"eslint": ">=9",

@marufrasully marufrasully added the eslint-plugin-fiori-tools @sap-ux/eslint-plugin-fiori-tools label Mar 24, 2026
Copy link
Copy Markdown
Contributor

@AlinaGovoruhina AlinaGovoruhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked changes in eslint-plugin-fiori-tools: deprecated methods removed, eslint types imports updated, also removed 'category' from the migrated rules, updated unit tests.
Tested linting a fiori project - plugin works as expected,

Copy link
Copy Markdown
Member

@igorsVoronins igorsVoronins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Report:
Successfully tested ESLint 10 compatibility with eslint-plugin-fiori-tools. Confirmed that:

  • ESLint 10 installs correctly alongside the plugin
  • Linting executes without issues
  • Auto-fix functionality works as expected
  • All implemented rules displayed correctly in the App Modeler extension

@longieirl
Copy link
Copy Markdown
Contributor

Possible fix for #4548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eslint-plugin-fiori-tools @sap-ux/eslint-plugin-fiori-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants