Conversation
🦋 Changeset detectedLatest commit: f6dd86b The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…uired web API polyfills
…t/support-eslint-10
|
@marufrasully please also adjust the convert command at https://github.com/SAP/open-ux-tools/blob/main/packages/app-config-writer/src/eslint-config/convert.ts#L279 |
@heimwege thanks. Done in this d2b3f1f#diff-2dc1a16f21816f00c65858cf874323d6fa0d4077dfcb676cec3a62875b683da8R279 |
|
| "eslint": "^9", | ||
| "typescript-eslint": "^8.46.2", | ||
| "@types/semver": "7.7.1" | ||
| "eslint": "^10", |
There was a problem hiding this comment.
@marufrasully do we really need to be so strict or could we just say
| "eslint": "^10", | |
| "eslint": ">=9", |
AlinaGovoruhina
left a comment
There was a problem hiding this comment.
Checked changes in eslint-plugin-fiori-tools: deprecated methods removed, eslint types imports updated, also removed 'category' from the migrated rules, updated unit tests.
Tested linting a fiori project - plugin works as expected,
igorsVoronins
left a comment
There was a problem hiding this comment.
QA Report:
Successfully tested ESLint 10 compatibility with eslint-plugin-fiori-tools. Confirmed that:
- ESLint 10 installs correctly alongside the plugin
- Linting executes without issues
- Auto-fix functionality works as expected
- All implemented rules displayed correctly in the App Modeler extension
|
Possible fix for #4548 |



This PR
@sap-ux/eslint-plugin-fiori-toolsto 10eslint-plugin-react@7.37.5incompatibility with ESLint 10@sap-ux/ui-prompting-examples@sap-ux/ui-components@sap-ux/control-property-editor@sap-ux/ui-promptingReason:
eslint-plugin-react@7.37.5uses deprecated ESLint APIs (specificallycontextOrFilename.getFilename()) that were removed in ESLint 10.