feat: support eslint 10

.changeset/fair-adults-cheat.md

@@ -0,0 +1,9 @@
+---
+'@sap-ux/eslint-plugin-fiori-tools': major
+'@sap-ux/app-config-writer': patch
+'@sap-ux/ui5-application-writer': patch
+'@sap-ux/ui5-library-writer': patch
+'@sap-ux-private/preview-middleware-client': patch
+---
+
+feat: support ESLint 10

.nvmrc

@@ -0,0 +1 @@
+20.20.0

examples/ui-prompting-examples/package.json

@@ -53,6 +53,7 @@
         "babel-loader": "10.1.1",
         "copyfiles": "2.4.1",
         "css-loader": "7.1.4",
+        "eslint": "9.39.1",
         "eslint-plugin-react": "7.37.5",
         "eslint-plugin-storybook": "0.6.15",
         "mem-fs": "2.1.0",

package.json

@@ -7,15 +7,15 @@
     "devDependencies": {
         "@changesets/cli": "2.30.0",
         "@eslint/eslintrc": "3.3.5",
-        "@eslint/js": "9.22.0",
+        "@eslint/js": "10.0.1",
         "@playwright/test": "1.58.2",
         "@types/jest": "30.0.0",
         "@types/node": "20.19.37",
         "autoprefixer": "10.4.27",
         "check-dependency-version-consistency": "6.0.0",
         "esbuild": "0.27.4",
         "esbuild-sass-plugin": "3.7.0",
-        "eslint": "9.39.1",
+        "eslint": "10.0.3",
         "eslint-config-prettier": "10.1.8",
         "eslint-import-resolver-typescript": "4.4.4",
         "eslint-plugin-import": "2.32.0",

packages/app-config-writer/src/eslint-config/convert.ts

@@ -369,8 +369,8 @@ async function updatePackageJson(basePath: string, fs: Editor, logger?: ToolsLog
     const packageJsonPath = join(basePath, FileName.Package);
     const packageJson = fs.readJSON(packageJsonPath) as Package;
     packageJson.devDependencies ??= {};
-    packageJson.devDependencies[packageName.ESLINT] = '^9.0.0';
-    packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_TOOLS] = '^9.0.0';
+    packageJson.devDependencies[packageName.ESLINT] = '^10.0.0';
+    packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_TOOLS] = '^10.0.0';
     delete packageJson.devDependencies[packageName.ESLINT_PLUGIN_FIORI_CUSTOM];
     packageJson.scripts ??= {};
     if (packageJson.scripts['lint']) {

packages/app-config-writer/test/unit/eslint-config/add.test.ts

@@ -79,8 +79,8 @@ describe('generateEslintConfig', () => {
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
             expect(packageJson.devDependencies).toBeDefined();
-            expect(packageJson.devDependencies?.eslint).toBe('^9');
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
         });
 
         test('should add lint script to package.json', async () => {

packages/app-config-writer/test/unit/eslint-config/convert.test.ts

@@ -610,7 +610,7 @@ describe('convertEslintConfig', () => {
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
-            expect(packageJson.devDependencies?.eslint).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10.0.0');
         });
 
         test('should update @sap-ux/eslint-plugin-fiori-tools version to ^9.0.0', async () => {
@@ -620,7 +620,7 @@ describe('convertEslintConfig', () => {
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
 
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
         });
 
         test('should preserve existing devDependencies', async () => {
@@ -660,7 +660,7 @@ describe('convertEslintConfig', () => {
 
             const updatedPackageJson = fs.readJSON(packageJsonPath) as Package;
             expect(updatedPackageJson.devDependencies).toBeDefined();
-            expect(updatedPackageJson.devDependencies?.eslint).toBe('^9.0.0');
+            expect(updatedPackageJson.devDependencies?.eslint).toBe('^10.0.0');
         });
     });
 
@@ -762,8 +762,8 @@ describe('convertEslintConfig', () => {
             // Verify package.json was updated
             const packageJsonPath = join(basePath, 'package.json');
             const packageJson = fs.readJSON(packageJsonPath) as Package;
-            expect(packageJson.devDependencies?.eslint).toBe('^9.0.0');
-            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^9.0.0');
+            expect(packageJson.devDependencies?.eslint).toBe('^10.0.0');
+            expect(packageJson.devDependencies?.['@sap-ux/eslint-plugin-fiori-tools']).toBe('^10.0.0');
 
             // Verify result is the fs instance
             expect(result).toBe(fs);

packages/control-property-editor/package.json

@@ -37,6 +37,7 @@
         "@types/remote-redux-devtools": "0.5.8",
         "@types/source-map-support": "0.5.10",
         "@types/react": "16.14.69",
+        "eslint": "9.39.1",
         "eslint-plugin-react": "7.37.5",
         "http-proxy-middleware": "3.0.5",
         "i18next": "25.10.10",

packages/eslint-plugin-fiori-tools/package.json

@@ -27,17 +27,18 @@
         "cross-env": "10.1.0",
         "eslint": "9.39.1",
         "@typescript-eslint/rule-tester": "8.57.2",
-        "eslint-plugin-eslint-plugin": "7.3.2"
+        "eslint-plugin-eslint-plugin": "7.3.2",
+        "@types/semver": "7.7.1"
     },
     "dependencies": {
         "@babel/core": "7.29.0",
         "@babel/eslint-parser": "^7.28.5",
-        "@eslint/js": "9.22.0",
+        "@eslint/js": "10.0.1",
         "@eslint/json": "0.14.0",
-        "@eslint/core": "0.17.0",
+        "@eslint/core": "1.1.1",
         "@eslint/config-helpers": "0.5.3",
-        "@typescript-eslint/eslint-plugin": ">=8.57.2",
-        "@typescript-eslint/parser": ">=8.57.2",
+        "@typescript-eslint/eslint-plugin": "8.57.2",
+        "@typescript-eslint/parser": "8.57.2",
         "@sap-ux/fiori-annotation-api": "workspace:*",
         "@sap-ux/odata-annotation-core": "workspace:*",
         "@sap-ux/odata-vocabularies": "workspace:*",
@@ -47,7 +48,7 @@
         "@xml-tools/ast": "5.0.5",
         "@xml-tools/parser": "1.0.11",
         "@humanwhocodes/momoa": "^3.3.9",
-        "@eslint/plugin-kit": "0.5.0",
+        "@eslint/plugin-kit": "0.6.1",
         "globals": "17.4.0",
         "lodash": "4.18.1",
         "requireindex": "^1.2.0",
@@ -56,7 +57,7 @@
         "semver": "7.7.4"
     },
     "peerDependencies": {
-        "eslint": "^9",
+        "eslint": ">=9",
         "typescript-eslint": "^8.57.2",
         "@types/semver": "7.7.1"
     },

packages/eslint-plugin-fiori-tools/src/index.ts

@@ -40,6 +40,8 @@ export const languages = {
     fiori: new FioriLanguage()
 };
 
+const fioriRules = rules as Plugin['rules'];
+
 /**
  * Default export following ESLint 9 plugin structure.
  * This is the recommended way to export plugins in ESLint 9.
@@ -52,7 +54,7 @@ const plugin: Plugin = {
         namespace: '@sap-ux/fiori-tools'
     },
     languages,
-    rules: rules as Plugin['rules'],
+    rules: fioriRules,
     processors: {}
 };
 
@@ -493,7 +495,7 @@ export const configs: Record<string, Linter.Config[]> = {
             plugins: {
                 '@sap-ux/fiori-tools': {
                     meta,
-                    rules: rules as Plugin['rules']
+                    rules: fioriRules
                 }
             }
         },
@@ -507,7 +509,7 @@ export const configs: Record<string, Linter.Config[]> = {
                 '@sap-ux/fiori-tools': {
                     meta,
                     languages,
-                    rules: rules as Plugin['rules']
+                    rules: fioriRules
                 }
             }
         },

packages/eslint-plugin-fiori-tools/src/language/annotations/types.ts

@@ -1,4 +1,5 @@
-import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions, RuleVisitor } from '@eslint/core';
+import type { RuleVisitor } from '@eslint/core';
+import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions } from '@eslint/plugin-kit';
 
 import type { FioriAnnotationSourceCode } from './source-code';
 import type { AnyNode } from '@sap-ux/odata-annotation-core';

packages/eslint-plugin-fiori-tools/src/language/json/types.ts

@@ -1,4 +1,5 @@
-import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions, RuleVisitor } from '@eslint/core';
+import type { RuleVisitor } from '@eslint/core';
+import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions } from '@eslint/plugin-kit';
 import type { JSONLanguageOptions } from '@eslint/json';
 import type { AnyNode } from '@humanwhocodes/momoa';
 

packages/eslint-plugin-fiori-tools/src/language/xml/types.ts

@@ -1,4 +1,5 @@
-import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions, RuleVisitor } from '@eslint/core';
+import type { RuleVisitor } from '@eslint/core';
+import type { CustomRuleDefinitionType, CustomRuleTypeDefinitions } from '@eslint/plugin-kit';
 import type { XMLAstNode, XMLToken } from '@xml-tools/ast';
 
 import type { FioriXMLSourceCode } from './source-code';

packages/eslint-plugin-fiori-tools/src/project-context/parser/service.ts

@@ -8,7 +8,7 @@ import {
     parseIdentifier,
     toFullyQualifiedName
 } from '@sap-ux/odata-annotation-core';
-import type { ServiceArtifacts } from '@sap-ux/fiori-annotation-api/src/types';
+import type { ServiceArtifacts } from '@sap-ux/fiori-annotation-api';
 
 import type { DocumentType } from '../types';
 

packages/eslint-plugin-fiori-tools/src/rules/sap-bookmark-performance.ts

@@ -28,7 +28,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-browser-api-error.ts

@@ -57,7 +57,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-browser-api-warning.ts

@@ -64,7 +64,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-cross-application-navigation.ts

@@ -227,7 +227,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-forbidden-window-property.ts

@@ -29,7 +29,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-message-toast.ts

@@ -48,7 +48,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-absolute-component-path.ts

@@ -28,7 +28,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-br-on-return.ts

@@ -13,7 +13,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-commons-usage.ts

@@ -55,7 +55,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-dom-access.ts

@@ -13,7 +13,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-dom-insertion.ts

@@ -48,7 +48,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-dynamic-style-insertion.ts

@@ -29,7 +29,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-element-creation.ts

@@ -20,7 +20,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-encode-file-service.ts

@@ -37,7 +37,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-event-prop.ts

@@ -30,7 +30,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-exec-command.ts

@@ -28,7 +28,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-global-define.ts

@@ -69,7 +69,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-global-event.ts

@@ -79,7 +79,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-global-selection.ts

@@ -20,7 +20,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-global-variable.ts

@@ -29,7 +29,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'disallow global variable declarations',
-            category: 'Best Practices',
             recommended: true
         },
         fixable: undefined,
@@ -48,7 +47,7 @@ const rule: Rule.RuleModule = {
 
         return {
             VariableDeclaration(node: ASTNode) {
-                const sourceCode = context.sourceCode ?? context.getSourceCode();
+                const sourceCode = context.sourceCode;
                 const scope: Scope.Scope = sourceCode.getScope
                     ? sourceCode.getScope(node)
                     : (context as any).getScope();

packages/eslint-plugin-fiori-tools/src/rules/sap-no-hardcoded-color.ts

@@ -32,7 +32,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {

packages/eslint-plugin-fiori-tools/src/rules/sap-no-hardcoded-url.ts

@@ -33,7 +33,6 @@ const rule: Rule.RuleModule = {
         type: 'problem',
         docs: {
             description: 'fiori tools (fiori custom) ESLint rule',
-            category: 'Best Practices',
             recommended: false
         },
         messages: {