Skip to content

Add unit tests covering authentication and reporting utilities - #372

Closed
samatstariongroup wants to merge 1 commit into
developmentfrom
codex/improve-code-coverage-for-specified-files
Closed

samatstariongroup wants to merge 1 commit into
developmentfrom
codex/improve-code-coverage-for-specified-files

Conversation

@samatstariongroup

Copy link
Copy Markdown
Member

Summary

  • add unit tests for authentication models, data-access catalogues, and HTTP header helpers
  • expand coverage for GUID utilities, boolean comparers, and parameter validation helpers
  • exercise OpenID Connect flows and reporting parameter/path utilities with dedicated tests

Testing

  • dotnet test CDP4Common.NetCore.Tests/CDP4Common.NetCore.Tests.csproj (fails: command not found)

https://chatgpt.com/codex/tasks/task_e_68f623d1a59c8326968fcbb7b10c2664

@samatstariongroup
samatstariongroup force-pushed the codex/improve-code-coverage-for-specified-files branch from f0ab242 to 85fe437 Compare October 20, 2025 13:55
@sonarqubecloud

Copy link
Copy Markdown

@samatstariongroup

Copy link
Copy Markdown
Member Author

Superseded by #415, which adds the useful tests from this PR to the current development branch (NUnit 5). It leaves out the tests that duplicate existing ones and fixes the file encoding.

samatstariongroup added a commit that referenced this pull request Oct 22, 2026
Ports the useful tests from #372 onto current development (NUnit 5):
- GuidExtensions short-guid round trips, ParameterValueValidator, AuthenticationInformation, HttpClientExtensions authorization header
- Reporting: DynamicTableCell, ReportingParameter, ReportingParameters filter string, ReportingUtilities.ToDataTable
- BooleanValueSetComparer string comparison fallback, added to the existing fixture
- OpenIdConnectService refresh-token flow, authorization-code flow and error status, merged into the existing fixture with awaited async asserts

Left out the tests that duplicate existing ones (AvailableDals, failed boolean conversion, unsupported scheme). Files converted to UTF-8 with BOM; usings grouped as in the rest of the repo.

Co-authored-by: samatstarion <s.gerene@stariongroup.eu>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant