Repository navigation
[Test] Add coverage tests ported from #372 - #415
Merged
Merged
Conversation
Ports the useful tests from #372 onto current development (NUnit 5): - GuidExtensions short-guid round trips, ParameterValueValidator, AuthenticationInformation, HttpClientExtensions authorization header - Reporting: DynamicTableCell, ReportingParameter, ReportingParameters filter string, ReportingUtilities.ToDataTable - BooleanValueSetComparer string comparison fallback, added to the existing fixture - OpenIdConnectService refresh-token flow, authorization-code flow and error status, merged into the existing fixture with awaited async asserts Left out the tests that duplicate existing ones (AvailableDals, failed boolean conversion, unsupported scheme). Files converted to UTF-8 with BOM; usings grouped as in the rest of the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Replaces #372, which conflicts with
developmentand does not compile under NUnit 5. This PR adds the useful tests from #372 to the currentdevelopmentbranch. It changes test code only and adds 21 tests.New fixtures (from #372)
GuidExtensionsTestFixture: round trips for a short GUID and a short GUID array.ParameterValueValidatorTestFixture: a null parameter type, a valid boolean value and an invalid boolean value.AuthenticationInformationTestFixture: both constructors.HttpClientExtensionsTestFixture: the Basic and bearerAuthorizationheaders.DynamicTableCellTestFixture,ReportingParameterTestFixture,ReportingParametersTestFixture(filter string) andReportingUtilitiesTestFixture(ToDataTable).Added to existing fixtures
BooleanValueSetComparerTestFixture: falls back to string comparison when conversion fails. It runs on net48 and net10.0.OpenIdConnectServiceTestFixture: the refresh-token flow, the authorization-code flow, and an error status reported asHttpRequestException. The tests use a localHttpListeneras the token endpoint and also check the request path. The async asserts are awaited, as NUnit 5 requires.Left out of #372
These tests are already covered by existing tests:
DAL/AvailableDalsTestFixture, already covered byComposition/AvailableDalsTestFixture.VerifyThatConversionToBooleanListFailsForInvalidValues.Verify_that_RequestAuthenticationToken_throws_when_scheme_missing_ExternalJwtBearer.Cleanup
Verification
🤖 Generated with Claude Code