Skip to content

fix: replace raw alert() calls with toast.error() notifications#1457

Open
Xenon010101 wants to merge 1 commit into
Sachinchaurasiya360:mainfrom
Xenon010101:fix/issue-1321-alert-to-toast
Open

fix: replace raw alert() calls with toast.error() notifications#1457
Xenon010101 wants to merge 1 commit into
Sachinchaurasiya360:mainfrom
Xenon010101:fix/issue-1321-alert-to-toast

Conversation

@Xenon010101
Copy link
Copy Markdown
Contributor

What

Replace raw browser alert() calls with the project's custom toast notification system.

Root cause

Several admin pages used browser alert() for error feedback, which blocks the main thread, cannot be styled, and creates inconsistent UX compared to the existing toast.error() usage in other files.

Changes

  • AdminSkillTestsPage.tsx: Added toast import, replaced 4 alert() calls in catch blocks with toast.error()

Verification

  • All replacements follow existing patterns (e.g. ApplicationDetail.tsx, EvaluationsList.tsx)
  • No new imports needed beyond toast which already exists in the project

CI failures

N/A

Before

4 catch blocks used alert() for error feedback.

After

All error feedback uses the project's styled toast.error() system.

Closes #1321

Replaced 4 browser alert() calls in AdminSkillTestsPage catch blocks
with the project's toast.error() system for consistent UI.

Closes Sachinchaurasiya360#1321

Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Warning

Review limit reached

@Xenon010101, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 400c4170-1a59-4e88-81a1-f75165dd7a02

📥 Commits

Reviewing files that changed from the base of the PR and between 0c176ae and 74f4441.

📒 Files selected for processing (1)
  • client/src/module/admin/skill-tests/AdminSkillTestsPage.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug Something isn't working gssoc gssoc:approved Approved for GSSoC scoring scope:frontend Changes to client-side / UI code labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Hi @Xenon010101, thanks for contributing to InternHack! 🎉

I have automatically:

  • 👤 Assigned this PR to you.
  • 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

  • 📈 PR Difficulty: level:*
  • 🧩 PR Type: type:*
  • 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀

@github-actions github-actions Bot added quality:exceptional Exceptional implementation quality type:bug Bug fixes level:beginner Good for first-time contributors labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:approved Approved for GSSoC scoring gssoc level:beginner Good for first-time contributors quality:exceptional Exceptional implementation quality scope:frontend Changes to client-side / UI code type:bug Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: replace raw alert()/confirm() with toast notifications

1 participant