fix: replace raw alert() calls with toast.error() notifications#1457
fix: replace raw alert() calls with toast.error() notifications#1457Xenon010101 wants to merge 1 commit into
Conversation
Replaced 4 browser alert() calls in AdminSkillTestsPage catch blocks with the project's toast.error() system for consistent UI. Closes Sachinchaurasiya360#1321 Signed-off-by: Xenon010101 <xenon010101@users.noreply.github.com>
|
Warning Review limit reached
More reviews will be available in 25 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Xenon010101, thanks for contributing to InternHack! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
What
Replace raw browser
alert()calls with the project's custom toast notification system.Root cause
Several admin pages used browser
alert()for error feedback, which blocks the main thread, cannot be styled, and creates inconsistent UX compared to the existingtoast.error()usage in other files.Changes
AdminSkillTestsPage.tsx: Added toast import, replaced 4alert()calls in catch blocks withtoast.error()Verification
ApplicationDetail.tsx,EvaluationsList.tsx)toastwhich already exists in the projectCI failures
N/A
Before
4 catch blocks used
alert()for error feedback.After
All error feedback uses the project's styled
toast.error()system.Closes #1321