Skip to content

fix: replace raw alert() calls with toast.error() notifications #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sachinchaurasiya360 merged 1 commit into from
Jun 6, 2026
Merged

fix: replace raw alert() calls with toast.error() notifications #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions client/src/module/admin/skill-tests/AdminSkillTestsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { BadgeCheck, Plus, Pencil, Trash2, ChevronDown, ChevronRight, Save, X, L
import { LoadingScreen } from "../../../components/LoadingScreen";
import api from "../../../lib/axios";
import { SEO } from "../../../components/SEO";
import toast from "../../../components/ui/toast";

interface SkillTestQuestion {
question: string;
Expand Down Expand Up @@ -63,7 +64,7 @@ export default function AdminSkillTestsPage() {
setEditing(data.test);
setCreating(false);
setExpandedQ(null);
} catch { alert("Failed to load test"); }
} catch { toast.error("Failed to load test"); }
};

const handleCreate = () => {
Expand All @@ -78,14 +79,14 @@ export default function AdminSkillTestsPage() {
await api.delete(`/admin/skill-tests/${id}`);
setTests((prev) => prev.filter((t) => t.id !== id));
if (editing?.id === id) { setEditing(null); setCreating(false); }
} catch { alert("Failed to delete"); }
} catch { toast.error("Failed to delete"); }
};

const handleToggle = async (id: number, isActive: boolean) => {
try {
await api.patch(`/admin/skill-tests/${id}/toggle`, { isActive });
setTests((prev) => prev.map((t) => t.id === id ? { ...t, isActive } : t));
} catch { alert("Failed to toggle"); }
} catch { toast.error("Failed to toggle"); }
};

const handleSave = async () => {
Expand Down Expand Up @@ -116,7 +117,7 @@ export default function AdminSkillTestsPage() {
setEditing(null);
setCreating(false);
fetchTests();
} catch { alert("Failed to save test"); }
} catch { toast.error("Failed to save test"); }
finally { setSaving(false); }
};

Expand Down
Loading