Skip to content

Fix/locale aware UI - #325

Merged
Github-Samuel merged 12 commits into
Samuels-Development:mainfrom
ziks29:fix/locale-aware-ui
Nov 11, 2026
Merged

Github-Samuel merged 12 commits into
Samuels-Development:mainfrom
ziks29:fix/locale-aware-ui

Conversation

@ziks29

@ziks29 ziks29 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Improve locale-aware dates, app names, built-in colors, attachment labels, sharing notifications and voice-upload errors.
  • Support Russian count labels while preserving existing count behavior in other shipped catalogs.
  • Separate Photogram comment-button wording from post headings, with legacy translation fallback.
  • Handle long localized navigation labels using a generic back label or chevron when necessary.
  • Preserve custom app names, player names, custom share kinds and legacy voice-upload error reasons.
  • Add 31 English/Russian keys plus code-dependent and nearby Russian labels. Bulk Russian wording corrections are isolated in a separate PR.

Type of Change

  • Bug Fix
  • New Feature
  • Improvement / Refactor
  • Performance
  • Documentation
  • Compatibility
  • Other

Related Issues

Not applicable.

Testing

  • Tested locally
  • Tested with latest sd-phone
  • Tested with latest ox_lib
  • Tested with latest ox_inventory
  • Multiplayer tested

Automated checks against current upstream main:

  • Localization validator passed: 7,234 source keys, no collisions, placeholders intact.
  • TypeScript checks and production build passed.
  • Targeted local regression tests passed for all 18 shipped languages: legacy count behavior, Photogram fallback, custom labels, share variables and valid date locales.
  • Five voice-error fallback tests passed, including unkeyed legacy reasons, unknown keys and recognized translated errors. The legacy-message tests reproduced the issue before the fix.
  • Existing English values and non-Russian catalogs are unchanged.
  • Verified a conflict-free merge with the separate Russian-corrections branch; together their Russian catalog matches the original combined review branch.

Regression harnesses were run locally and are not added to the repository. No in-game, visual or multiplayer verification was performed in this preparation.

Breaking Changes

None expected. Missing translation keys retain fallbacks, legacy count behavior is preserved for unmigrated catalogs, and unkeyed/custom voice errors retain their supplied text.


Checklist

  • My code follows the existing style of the project.
  • I have tested my changes.
  • I have updated any necessary documentation.
  • I have removed any debug code.
  • This PR does not include unrelated changes.
  • I have verified this works on the latest version of sd-phone.

@Github-Samuel
Github-Samuel merged commit 5869254 into Samuels-Development:main Nov 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants