Repository navigation
Fix: cut a tile label at the end of its own name - #174
Merged
Merged
Conversation
A tile label took its direction from the page, so a Latin name on a right-to-left dashboard was truncated at its start. The labels are centred, so taking the direction from the name moves no text.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dir="auto"on.ilabel,.dyn-mob-label,.dyn-fold-labeland.dyn-fold-inner-labelat each creation site, so a label takes its direction from the name it holds and ellipsises at that name's end.unicode-bidi:plaintextmoves the cut in Blink but is ignored by WebKit, where the label was clipped at both ends. The labels are centred, sodircannot move them off their icons.Testing
All green, plus the Docker build. Added 2 tests, verified to fail without the change, and confirmed the rendering in WebKit and Blink against a container.
Checklist