Repository navigation
Security: restore stored secrets only for the same widget type and destination - #484
Merged
Merged
Conversation
Run migrations on an incoming config before refilling secrets, and refill a widget secret only when the stored item has the same widget type. Count a removed or emptied port map, and a change of the global certificate skip, as a destination change. Name a withheld widget with no manifest when a rewrite change clears its config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrateon the incoming config beforepreserveAllSecretsinPOST /api/config, so a legacy widget type is renamed before secrets are matched.widgetType, inpreserveAllSecretsand inPOST /api/widget-options.settings.server.portMapas a rewrite change inrewriteChanged.settings.server.skipTlsVerifyis turned on or off.withheldwhen a rewrite or certificate change clears its stored config.Testing
All green. Added 9 tests covering legacy-type saves, type changes on save and options fetch, port map removal, the global certificate skip and withheld unknown widgets.
Changelog
Security
Fixed
Checklist