ci(release): verify pkg.pr.new artifacts - #819
Conversation
|
ScriptedAlchemy
added
the
skip-changeset
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f912cac7d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| release: | ||
| name: Version Packages / release | ||
| name: Version Packages / verify release | ||
| needs: preview |
There was a problem hiding this comment.
When the preview job fails or is cancelled, GitHub skips this entire dependent job because needs defaults to requiring success, so the step-level if: always() on the summary is never evaluated. This also prevents changesets/action from maintaining the Version Packages PR and means the documented failed outcome is not written; use an independent always-running summary job or a job-level always() condition with the operational steps gated separately.
AGENTS.md reference: AGENTS.md:L96-L99
Useful? React with 👍 / 👎.
| Packages are distributed through pkg.pr.new, not the npm registry. Install the | ||
| preview tarballs CI publishes for every commit and pull request: |
There was a problem hiding this comment.
This now presents pkg.pr.new rather than npm as the distribution policy, but the same README still says at line 103 that pkg.pr.new is only the release channel until a final npm package name is chosen. Under this commit's owner correction those statements are mutually exclusive, leaving consumers unsure whether npm distribution is still planned; update the Status section to match the new policy.
AGENTS.md reference: AGENTS.md:L96-L99
Useful? React with 👍 / 👎.
commit: |
f912cac to
9c52974
Compare
1 participant
Owner correction: agent-bundle distribution is pkg.pr.new only; npm publishing is not configured or expected.
Summary
package-preview.ymlfromrelease.yml, publish once, and verify all four commit-addressed pkg.pr.new URLspnpm check:release, and remove every npm publish/token pathFor a Version Packages merge, a green
Release packagesworkflow now means its merge SHA preview resolved foragent-bundle,@agent-bundle/runtime,rsc-markdown-stream, andcreate-agent-bundle, and the packed release gates passed.Version Packages #809
Safe to merge after this PR lands: it only deletes its consumed changeset, bumps
create-agent-bundle, and updates its changelog. Its candidate CI and release-candidate statuses are green. The resulting main push cannot runchangeset publishornpm publish; it publishes and verifies the four pkg.pr.new URLs, then runspnpm check:release.Verification
actionlint .github/workflows/release.yml .github/workflows/package-preview.ymlbash -n scripts/verify-preview-artifacts.sh scripts/release-outcome-summary.shpnpm buildpnpm typecheckpnpm lintpnpm test:unitpnpm check:release:cipnpm docs:site:builde57c0ac9c2c3a2d837ffc5603e28c96b309d0821Changeset
Workflow, tests, scripts, and documentation only; apply
skip-changeset.Merge qualification
Rebased onto current main
7c96689a1bwith an unchanged patch ID. Build, typecheck, lint, docs build (zero broken links), 4,462 unit tests, and packed CI qualification (46 tests, zero failures) passed. Independent different-model review: PASS. Distribution remains commit-addressed pkg.pr.new only.