-
Notifications
You must be signed in to change notification settings - Fork 0
ci(release): verify pkg.pr.new artifacts #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,8 @@ Requires Node.js 22.19 or later. | |
|
|
||
| ## Install | ||
|
|
||
| Nothing is published to npm yet (the `agent-bundle` name on npm currently belongs to an unrelated project). Until the first release, install the preview tarballs CI publishes for every commit and pull request: | ||
| Packages are distributed through pkg.pr.new, not the npm registry. Install the | ||
| preview tarballs CI publishes for every commit and pull request: | ||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This now presents pkg.pr.new rather than npm as the distribution policy, but the same README still says at line 103 that pkg.pr.new is only the release channel until a final npm package name is chosen. Under this commit's owner correction those statements are mutually exclusive, leaving consumers unsure whether npm distribution is still planned; update the Status section to match the new policy. AGENTS.md reference: AGENTS.md:L96-L99 Useful? React with 👍 / 👎. |
||
|
|
||
| ```sh | ||
| npm i -D https://pkg.pr.new/ScriptedAlchemy/agent-bundle/agent-bundle@<sha-or-pr> | ||
|
|
@@ -26,9 +27,8 @@ project that already passes its own `check`: | |
| npx https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@<sha-or-pr> my-plugin | ||
| ``` | ||
|
|
||
| (`npm create agent-bundle` once npm releases exist. See the | ||
| [create-agent-bundle README](packages/create-agent-bundle/README.md) for | ||
| templates and flags.) | ||
| See the [create-agent-bundle README](packages/create-agent-bundle/README.md) | ||
| for templates and flags. | ||
|
|
||
| Or describe the plugin by hand in `agent-bundle.config.ts` at the project root: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the
previewjob fails or is cancelled, GitHub skips this entire dependent job becauseneedsdefaults to requiring success, so the step-levelif: always()on the summary is never evaluated. This also preventschangesets/actionfrom maintaining the Version Packages PR and means the documentedfailedoutcome is not written; use an independent always-running summary job or a job-levelalways()condition with the operational steps gated separately.AGENTS.md reference: AGENTS.md:L96-L99
Useful? React with 👍 / 👎.