Skip to content

fix: bound gbot_thread output and add transcript changeset - #32

Merged
ScriptedAlchemy merged 4 commits into
mainfrom
fix/plugin-thread-bounds
Sep 15, 2026
Merged

ScriptedAlchemy merged 4 commits into
mainfrom
fix/plugin-thread-bounds

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Why

Post-merge Sol reviews of #27/#28 left publish blockers before #29:

What

  • Cap MCP thread entry text at 400 chars with ; tighten tool JSON Schema
  • Patch changeset for shared transcript / bot-reply text fix
  • scripts/run-unit-tests.mjs enumerates test/*.test.js (no shell glob)
  • takeLeadingGlobals + optional -- after thread id
  • windows-unsupported status/mode + README note
  • Strip CSI/OSC from list-threads text output

Not in this PR

Verify

  • npm test → 75/75
  • Plugin route-unit still 6/6 on the earlier commit (unchanged contract aside from truncation)

Hold #29 until this merges.

Cap each MCP thread entry at 400 chars (CLI parity) with an ellipsis
marker; tighten tool JSON Schema; add the missing patch changeset for
shared transcript parsing that fixed empty bot replies.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T01:19:13.399763Z f36a708 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Peel global flags only before the command so message tokens like
--json survive; refuse native Windows for gbot codex with a clear
mode; strip terminal controls from list-threads; run unit tests via
scripts/run-unit-tests.mjs for Windows/Node 18 without shell globs.
@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9f103bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
grok-bot-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Keep Zod runtime bounds; Agent Bundle preview only allows scalar
type/default/description in tool JSON Schema metadata.
@ScriptedAlchemy
ScriptedAlchemy merged commit 93cb28e into main Sep 15, 2026
2 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/plugin-thread-bounds branch September 15, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant