Report attached-shim from codex status when the desktop-shim is active - #60
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ebef9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Changeset fixed — |
Owner
Author
|
Whip: Package CI stuck queued >30m after runner free; close/reopen to re-fire CI. |
ScriptedAlchemy
force-pushed
the
cursor/potato-shim-status-0a7b
branch
from
September 16, 2026 01:00
9432399 to
516e7ff
Compare
ScriptedAlchemy
marked this pull request as ready for review
September 16, 2026 01:05
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Clear GROK_BOT_CODEX_EXPERIMENTAL in the rejection-envelope case so a host export cannot flip "experimental off" into unknown-status. For attached-shim live wiring on Darwin, mock launchctl getenv (GUI domain) via desktopShimStatus and inject that shim state into codexStatus without changing product GUI-domain semantics.
ScriptedAlchemy
force-pushed
the
cursor/potato-shim-status-0a7b
branch
from
September 16, 2026 01:07
50678c6 to
6ebef9a
Compare
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Sep 16, 2026
Publish attached-shim status (#60) to npm. 0.4.3 was on main but never published due to runner starvation + leftover changeset; this ships 0.4.4 as latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potato fix for the shim/status truth gap: Bridge Ops proved Desktop injects via desktop-shim, but
gbot codex statusstill reportedprivate-stdio(orunknown) because the process-list detector outranked — or ignored — the shim path.codexStatusnow checksdesktopShimStatusfirst: installed wrapper + Desktop-facingCODEX_CLI_PATH(GUI domain on Darwin) pointing at it reportsdesktopAttached: "attached-shim", outranking a stale-looking private-stdio process list. Inactive shim defers to the existingdetectDesktopPrivateAppServerbehavior (private-stdio/unknown).desktop-shim.jsinlines its socket resolution (wascodexSocketPath) socodex-bridgecan reusedesktopShimStatuswithout an import cycle; resolution semantics unchanged (CODEX_APP_SERVER_SOCKwins, else install-timeCODEX_HOME).formatCodexStatusprintsdesktop attached: attached-shim (Desktop shim bridges onto the managed daemon).Hunches discarded: the MATCH2 regex needs no change — a shim-mediated spawn line carries no
ChatGPT.app, so the detector was matching a stale pre-relaunchResources/codexchild (or equivalent), not false-positiving on the shim itself. Priority, not regex, is the fix.Verification: new
codexStatustest (active shim +DESKTOP_MAC_PSsample →attached-shim; installed-but-unpointed →private-stdio; quiet →unknown; plus live wiring through real wrapper/bridge files +CODEX_CLI_PATH),formatCodexStatusattached-shim line, desktop-shim suite 43/43, typecheck +validateclean, route tests pass. Full unit file: 19 pass / 43 fail — identical 43 failures at base (the bundled CLI doesn't self-execute in this VM, so all CLI-spawn tests fail environmentally here; CI is the real gate). Ripwire is not installed in this environment, so verification usednode --testdirectly.