Fix Desktop attachment status to reflect observed evidence - #65
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f7fbeea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gbot codex statusreportedattached-shimwhenever the installed wrapper matched Desktop's launch environment, including with an absent daemon socket. A running Desktop may not have inherited that environment or may have fallen back to stock Codex.Report
desktopShimConfiguredindependently, preserve observed private-stdio processes, and leave managed attachment unverified. Display the configuration on failed daemon probes too. The README and patch changeset explain that consumers checking setup should migrate fromattached-shimtodesktopShimConfigured.Validation: three regression tests failed before the fix and passed afterward;
npm run checkpassed (203 unit tests, 13 route tests, build, artifact validation and typecheck). A fresh built CLI against the existing Mac daemon reportsdesktopShimConfigured: true,desktopAttached: "unknown", and an exact 0.154.0 schema match. This is a status probe, not a live Desktop shared-thread proof.