Skip to content

test: assert observable CLI behavior #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 4 commits into from
Sep 16, 2026
Merged

test: assert observable CLI behavior #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
829a6f5
test: assert observable CLI behavior
ScriptedAlchemy Sep 16, 2026
e0b8351
test: smoke the packed grok-bot executable alias
ScriptedAlchemy Sep 16, 2026
95978a9
test: tidy codex contract suite
ScriptedAlchemy Sep 16, 2026
717dce5
Merge remote-tracking branch 'origin/test-behavior-audit-50-51' into …
ScriptedAlchemy Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,5 @@ jobs:
test "${#package_files[@]}" -eq 1
npm install --global --prefix "$install_root" "${package_files[0]}"
"$install_root/bin/gbot" --help
"$install_root/bin/grok-bot" --help
"$install_root/bin/gbot-install" --help
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
test "${#package_files[@]}" -eq 1
npm install --global --prefix "$install_root" "${package_files[0]}"
"$install_root/bin/gbot" --help
"$install_root/bin/grok-bot" --help
"$install_root/bin/gbot-install" --help

- name: Create release pull request or publish
Expand Down
13 changes: 1 addition & 12 deletions test/codex-contract.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,6 @@ describe("codex contract — outcomeFromError", () => {
assert.equal(out.delivery, "rejected");
assert.equal(out.exitCode, 1);
});

it("keeps the bridge reason strings verbatim", () => {
const reasons = ["busy", "hop-limit", "route-not-allowed", "thread-error", "unknown-status", "unknown-thread", "external-owner", "experimental-disabled", "unsupported", "rejected", "transport", "bad-response", "approval-refused", "usage"];
for (const reason of reasons) {
const out = outcomeFromError(
Object.assign(new Error(reason), { delivery: "rejected", reason }),
);
assert.equal(out.reason, reason);
assert.equal(out.exitCode, 1);
}
});
});

describe("codex contract — outcomeFromReceipt", () => {
Expand All @@ -110,6 +99,6 @@ describe("codex contract — outcomeFromReceipt", () => {
refused: ["approvals/request"],
});
assert.equal(out.exitCode, 1);
assert.ok(typeof out.error === "string" && out.error.length > 0);
assert.equal(out.error, "Codex refused one or more approvals.");
});
});
10 changes: 0 additions & 10 deletions test/release-config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,3 @@ test("npm package metadata identifies the public source repository", () => {
url: "https://github.com/ScriptedAlchemy/grok-bot-cli/issues",
});
});

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep coverage for the grok-bot executable alias

Deleting this test leaves the published grok-bot command unverified: the packed-package smoke test in .github/workflows/ci.yml invokes only gbot and gbot-install, while package.json still exposes the long-standing grok-bot alias. If that alias is removed or misspelled, CI will remain green but existing users invoking grok-bot will lose their executable; retain a focused alias assertion or execute it in the packed-package smoke test.

Useful? React with 👍 / 👎.


test("npm executable paths point at the Agent Bundle dist bins", () => {
assert.deepEqual(packageJson.bin, {
gbot: "./dist/bin/gbot.mjs",
"gbot-install": "./dist/bin/gbot-install.js",
"grok-bot": "./dist/bin/gbot.mjs",
});
assert.deepEqual(packageJson.files, ["dist", "README.md", "CHANGELOG.md", "LICENSE"]);
assert.equal(packageJson.scripts.prepack, "agent-bundle prepack");
});