Skip to content

refactor: remove legacy API paths - #69

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
refactor/remove-legacy-apis
Sep 16, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
refactor/remove-legacy-apis

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • remove the legacy chat command alias and migrate its tests/docs to gbot thread
  • remove undocumented auth, gateway, backend, localhost, and agents-root environment aliases; keep the documented GROK_BOT_* / CURSOR_* inputs
  • require canonical { entries } transcript containers and id entry identifiers, migrate the MCP caller, and delete compatibility-only tests
  • flatten Codex error correlation fields at their producers while preserving the feat(codex): machine-readable contract, delivery envelope, busy-thread refusal (#37 #38 #39) #46 reason / mode / delivery machine contract
  • narrow internal-only src/core/** exports and replace scripts/run-unit-tests.mjs with Node's native glob plus test.env
  • remove stale root-collapse migration prose and update README plus talk-to-grok-bot

Changeset: .changeset/remove-legacy-apis.md (minor).

Kept intentionally

  • desktop-shim and its fail-open behavior are product functionality, not a legacy shim
  • URL allowlists, credential redaction, redirect refusal, and response bounds remain intact
  • on-disk Grok Bot gateway descriptor v1/v2 parsing remains for persisted-data upgrades
  • feat(codex): machine-readable contract, delivery envelope, busy-thread refusal (#37 #38 #39) #46 machine vocabulary and the single grok-bot package bin alias remain public contracts
  • SAND_CLIENT_VERSION / SAND_BOX_NAMESPACE remain EnsureSandBox request metadata, not aliases for canonical config
  • camel/snake EnsureSandBox response parsing remains an external trust-boundary parser

Verification

  • npm ci --ignore-scripts — pass, package lock unchanged
  • npm run check — pass: Agent Bundle source/artifact validation, build, typecheck, 202/202 Node unit tests, 14/14 route-unit tests
  • npm pack into a clean temporary consumer — pass; tarball contains no src/, scripts/, or test.env; gbot --help, grok-bot --help, and gbot-install --help pass
  • Fable change-risk-reviewer — no remaining semantic findings after fixes

@changeset-bot

changeset-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6ee55dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
grok-bot-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T08:40:03.178119Z 6ee55dd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit aeb5ebf into main Sep 16, 2026
2 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the refactor/remove-legacy-apis branch September 16, 2026 09:01
@github-actions github-actions Bot mentioned this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant