Skip to content

fix: unblock Windows release validation and executable smoke #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 2 commits into from
Sep 17, 2026
+12 −7
Merged

fix: unblock Windows release validation and executable smoke #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
758ed11
fix: run the Windows release checks with native paths
ScriptedAlchemy Sep 17, 2026
d0d6f0a
test: retain the existing shell bridge guard
ScriptedAlchemy Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ jobs:
package_files=("$package_root"/*.tgz)
test -f "${package_files[0]}"
test "${#package_files[@]}" -eq 1
npm install --global --prefix "$install_root" "${package_files[0]}"
"$install_root/bin/gbot" --help
"$install_root/bin/grok-bot" --help
"$install_root/bin/gbot-install" --help
npm install --prefix "$install_root" "${package_files[0]}"
npm exec --prefix "$install_root" --no -- gbot --help
npm exec --prefix "$install_root" --no -- grok-bot --help
npm exec --prefix "$install_root" --no -- gbot-install --help

- name: Create release pull request or publish
id: changesets
Expand Down
2 changes: 1 addition & 1 deletion scripts/run-unit-tests.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const files = readdirSync(dir)
.sort()
.map((name) => join("test", name))
.filter((name) => {
if (process.platform === "win32" && skipOnWindows.has(name)) {
if (process.platform === "win32" && skipOnWindows.has(name.replaceAll("\\", "/"))) {
console.error(`skip ${name}: Unix sockets and Codex routes are unsupported on win32`);
return false;
}
Expand Down
8 changes: 6 additions & 2 deletions test/desktop-shim.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ test("install then uninstall round-trips in a scratch Codex home (no live Deskto
assert.equal(gone.installed, false);
});

test("darwin install writes the LaunchAgent and drives it through the runner", () => {
test("darwin install writes the LaunchAgent and drives it through the runner", {
skip: process.platform === "win32" && "Unix executable bits are unsupported on Windows",
}, () => {
const home = mkdtempSync(join(tmpdir(), "gbot-shim-mac-home-"));
const codexHome = mkdtempSync(join(tmpdir(), "gbot-shim-mac-codex-"));
const env = { CODEX_HOME: codexHome, HOME: home };
Expand Down Expand Up @@ -1060,7 +1062,9 @@ test("uninstall reports only paths that existed before delete", () => {
assert.deepEqual(empty.removed, [], "nothing installed, nothing reported removed");
});

test("linux status quotes the export path for spaces", () => {
test("linux status quotes the export path for spaces", {
skip: process.platform === "win32" && "Unix executable bits are unsupported on Windows",
}, () => {
const home = mkdtempSync(join(tmpdir(), "gbot-shim-quote-home-"));
const codexHome = mkdtempSync(join(tmpdir(), "gbot-shim-quote-codex-"));
const installed = installDesktopShim({
Expand Down
1 change: 1 addition & 0 deletions test/test-runner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ console.log("bootstrap-policy-verified");
const childEnv = { ...process.env, GROK_BOT_TEST: inherited, NODE_ENV: "production" };
delete childEnv.NODE_TEST_CONTEXT;
const result = spawnSync(process.platform === "win32" ? "npm.cmd" : "npm", ["run", "test:unit"], {
shell: process.platform === "win32",
cwd: fixture,
env: childEnv,
encoding: "utf8",
Expand Down