StatefulModeSDecoder: only decode valid positions#35
Merged
Conversation
mrksngl
requested changes
Feb 27, 2026
Using the StatefulModeSDecoder alone without any (external) extensions, this is not a problem: a position is not valid if and only if it originates from a FTC=0 message (following the implementation of all PositionMessages, this is the definition of hasValidPosition) . However, that decoder "discards" those messages (or rather: does not decode them), thus a "invalid position" messages never makes it to the erroneous control flow. However, if such FTC=0 messages are manually handled, they resolve into classes implementing interface PositionMsg and can then be fed into extractPosition from where we go down the described path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the StatefulModeSDecoder alone without any (external) extensions,
this is not a problem: a position is not valid if and only if it
originates from a FTC=0 message (following the implementation of all
PositionMessages, this is the definition of hasValidPosition) . However,
that decoder "discards" those messages (or rather: does not decode
them), thus a "invalid position" messages never makes it to the
erroneous control flow.
However, if such FTC=0 messages are manually handled, they resolve into
classes implementing interface PositionMsg and can then be fed into
extractPosition from where we go down the described path.
Fixes #32